Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Spark version for regression tests #168

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

flyrain
Copy link
Contributor

@flyrain flyrain commented Aug 21, 2024

Description

Spark-3.5.1 distribution isn't there anymore. The download always failed.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Run the regtest run.sh locally to download missing spark distribution

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review of my code

@flyrain flyrain requested a review from a team as a code owner August 21, 2024 01:29
@flyrain
Copy link
Contributor Author

flyrain commented Aug 21, 2024

It should be fine for here(https://github.com/polaris-catalog/polaris/blob/8510e9f373222478eefa396de330a094cb34f60d/regtests/Dockerfile#L43-L43), as the SPARK_HOME is always set when it comes to docker build.


```
./setup.sh
```
Copy link
Contributor Author

@flyrain flyrain Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't work independently locally, but I guess it's fine to remove it.

@flyrain
Copy link
Contributor Author

flyrain commented Aug 21, 2024

cc @collado-mike @dennishuo @aihuaxu

Copy link
Contributor

@aihuaxu aihuaxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@flyrain
Copy link
Contributor Author

flyrain commented Aug 21, 2024

cc @snazy @RussellSpitzer

@RussellSpitzer RussellSpitzer merged commit 60ec292 into apache:main Aug 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants