Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minimum resources for ASF landing #174

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Add minimum resources for ASF landing #174

merged 1 commit into from
Aug 22, 2024

Conversation

jbonofre
Copy link
Member

No description provided.

@jbonofre jbonofre mentioned this pull request Aug 21, 2024
Closed
@jbonofre
Copy link
Member Author

@snazy do you mind to review ? I would like to merge at least .asf.yml

rdblue
rdblue reviewed Aug 21, 2024
View reviewed changes
.asf.yml Outdated Show resolved Hide resolved
rdblue
rdblue reviewed Aug 21, 2024
View reviewed changes
NOTICE Show resolved Hide resolved
rdblue
rdblue requested changes Aug 21, 2024
View reviewed changes
Copy link

@rdblue rdblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, but I think that someone from Snowflake needs to be involved in the header changes to follow ASF policy.

@jbonofre
Copy link
Member Author

@rdblue that's right, I talked with @takidau.

snazy
snazy reviewed Aug 22, 2024
View reviewed changes
.asf.yml Outdated Show resolved Hide resolved
.asf.yml Outdated Show resolved Hide resolved
snazy
snazy reviewed Aug 22, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@snazy snazy mentioned this pull request Aug 22, 2024
Merged
@jbonofre jbonofre force-pushed the jbonofre-asf branch 2 times, most recently from f0c4132 to 1097764 Compare August 22, 2024 11:53
snazy
snazy reviewed Aug 22, 2024
View reviewed changes
Copy link
Member

@snazy snazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@snazy snazy mentioned this pull request Aug 22, 2024
Merged
takidau
takidau approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@takidau takidau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, JB! LGTM.

@jbonofre
Copy link
Member Author

@rdblue Do you mind to approve the request ? I addressed your comment and @takidau just approved the PR. Thanks !

rdblue
rdblue approved these changes Aug 22, 2024
View reviewed changes
Copy link

@rdblue rdblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think it is generally better to have someone from Snowflake replace headers, but good that it was approved by @takidau.

@jbonofre jbonofre merged commit 3c99199 into apache:main Aug 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takidau takidau takidau approved these changes

@snazy snazy snazy approved these changes

@rdblue rdblue rdblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbonofre @rdblue @snazy @takidau