Remove circular dependency between entity and api schema #1990
Conversation
| @@ -981,7 +983,7 @@ public PrincipalWithCredentials createPrincipal(PolarisEntity entity) { | |||
| entity.getName()); | |||
| } | |||
| return new PrincipalWithCredentials( | |||
| new PrincipalEntity(principalResult.getPrincipal()).asPrincipal(), | |||
| toPrincipal(new PrincipalEntity(principalResult.getPrincipal())), | |||
There was a problem hiding this comment.
Not a big fan of the static imports outside of test code
There was a problem hiding this comment.
Overall this looks like a good change to me. I have one doubt after reading #780 though -- is it possible to actually remove the dependency after this change? As in, the gradle dependency?
|
|
||
| public final class EntityConverter { | ||
|
|
||
| public static Catalog toCatalog(CatalogEntity entity) { |
There was a problem hiding this comment.
Does this actually remove the circular dependency? The old CatalogEntity.asCatalog() method and this method do the same thing and exist in the case package 🤔
There was a problem hiding this comment.
I didn't see any circular dependency in the code base. Here is the current dependency tree
polaris-api-management-modeldepends no onepolaris-coredepends onpolaris-api-management-modelpolaris-api-management-servicedepends onpolaris-api-management-modelandpolaris-core.
|
This change is a very good step to remove the dependency of (low level) persistence concerns to (high level) API concerns, which can be, as you mentioned in the PR summary, considered a circular dependency. I do support this change. |
This pr is made to remove the direct dependency of API schema in the entity class as mentioned in #780