Enable ErrorProne FallThrough, MissingCasesInEnumSwitch, OrphanedFormatString #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
requested review from
jbonofre,
ashvina,
RussellSpitzer,
snazy,
vvcephei and
jackye1995
as code owners
ebyhr
force-pushed
the
ebi/ep-FallThrough
branch
from
6d9edea
to
8b8ef97
Compare
snazy
reviewed
Aug 25, 2024
polaris-service/src/main/java/io/polaris/service/catalog/PolarisCatalogHandlerWrapper.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/ep-FallThrough
branch
from
8b8ef97
to
1dea06d
Compare
ebyhr
changed the title
sfc-gh-emaynard
approved these changes
Aug 26, 2024
snazy
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable ErrorProne FallThrough, MissingCasesInEnumSwitch, OrphanedFormatString
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist:
Please delete options that are not relevant.