Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename test classes of metastore manager + fix typo #203

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

ebyhr
Copy link
Contributor

@ebyhr ebyhr commented Aug 24, 2024

Description

Rename test classes of metastore manager + fix typo

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review of my code

RussellSpitzer
RussellSpitzer previously approved these changes Aug 26, 2024
Copy link
Member

@RussellSpitzer RussellSpitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge when tests pass

@ebyhr
Copy link
Contributor Author

ebyhr commented Aug 26, 2024

The build failed due to wrong import order. Pushded a new change.

@takidau takidau merged commit 2d572d2 into apache:main Aug 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants