Support buckets containing underscore #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-maynard
requested review from
jbonofre,
ashvina,
RussellSpitzer,
snazy,
vvcephei,
takidau and
jackye1995
as code owners
nk1506
reviewed
Sep 5, 2024
| @@ -73,7 +73,7 @@ PolarisStorageIntegration<T> getStorageIntegrationForConfig( | |||
| HttpTransportFactory.class, NetHttpTransport::new)); | |||
| } catch (IOException e) { | |||
| throw new RuntimeException( | |||
| "Error initializing default google credentials" + e.getMessage()); | |||
| "Error initializing default google credentials. " + e.getMessage()); | |||
There was a problem hiding this comment.
nit: not related to this fix.
nk1506
reviewed
Sep 6, 2024
| } | ||
|
|
||
| @ParameterizedTest | ||
| @ValueSource(strings = {"s3", "gcs", "azure"}) |
RussellSpitzer
approved these changes
Sep 9, 2024
|
Thanks @eric-maynard and thanks @nk1506 for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, we are using
URI.getHostto extract the bucket from paths, which can returnnullunexpectedly when the bucket contains an underscore. This seems to be a known issue.This PR introduces a thin new utility for extracting the path and adds a test for it.
Fixes #262
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added a new suite,
StorageUtilTest.Checklist:
Please delete options that are not relevant.