-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
License: add missing notices related to eclipselink #271
Conversation
@@ -2110,6 +2334,255 @@ do so. If you do not wish to do so, delete this exception statement | |||
from your version. | |||
|
|||
|
|||
--- | |||
com.sun.xml.bind:jaxb-xjc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just move this like below line 1352, if the license is exactly the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me it doesn't look the same, on line 2371 there is a mention Copyright (c) 2004 Kohsuke Kawaguchi
that is not present in jaxb-core
license.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
permitted. | ||
|
||
--- | ||
jakarta.xml.bind:jakarta.xml.bind-api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here - the licenses for Jakarta look the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I see that are divergences:
jakarta.annotation:jakarta.annotation-api
jakarta.el:jakarta.el-api
jakarta.servlet:jakarta.servlet-api
jakarta.ws.rs:jakarta.ws.rs-api
=> EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
jakarta.xml.bind:jakarta.xml.bind-api
=> BSD-3-Clause (+Oracle preamble?)
jakarta.persistence:jakarta.persistence-api (new)
=> EPL-2.0 OR BSD-3-Clause
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
Description
Build is failing when property
eclipseLink
is true:Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
./gradlew clean build -PeclipseLink=true
now passesChecklist:
Please delete options that are not relevant.