Add support for Python3.13, fix running test on localhost, and move regression tests to pytest #545
+1,895
−1,467
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #21
High level changes:
While trying to run regtest on local with Python 3.13, it failed on installing
pydantic-core
:This then prevents the installation of
pytest
which then fails all tests that are based onpytest
.Fix running test on localhost
Also,
regtests/t_cli/src/test_cli.py
set default polaris host topolaris
which can be problematic (as we are not documenting extra set for setting hostname anywhere for running test on local. Thus, better to set this tolocalhost
instead.Move all regression tests to pytests
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Detail changes summary:
AWS_TEST_BASE
reference due to bad incomplete logic in the test cases (we should create a diff test case for this)regtests
tox
from>=3.9.0
to>=4.19.0
as that is the first version that support Python 3.13platformdirs
to4.3.6
asvirtualenv
has>=3.9.1,<5
and will try to downgrade version to3.11.0
during rerun of local testregtests/pyspark-setup.sh
,regtests/run_spark_sql.sh
andregtests/setup.sh
as these two are no longer neededregtests/runsh
to perform regression tests on pytests onlylocalhost
as default value for polaris host instead ofpolaris
to support running regression tests not within docker (still do-able without this change if we want to add document to ask user to setPOLARIS_HOST
)conftest.py
andiceberg_spark.py
Things I didn't do
regtests/t_pyspark/src/test_spark_sql_s3_with_privileges.py
. I can do another follow up PR to refactor all of them to more standard layout/format after current PR. Also, we should removesnowflake
in this file in the next PR.Test results:
Checklist:
Please delete options that are not relevant.