Fix default operation timeout #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
approved these changes
Oct 26, 2024
|
There seems to be something wrong with the CI, I will take a look next week |
|
@arhoads Could you rebase to the latest main branch, which has fixed the CI? |
arhoads
force-pushed
the
fix-default-operation-timeout
branch
from
1913eef
to
78feabb
Compare
RobertIndie
approved these changes
Oct 30, 2024
shibd
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: Default operation timeout has the wrong value (no issue entered)
Motivation
The driver will timeout on all operations because the operation timeout is initialized with a literal of a too small size and when cast to
std::chrono::secondswe end up with 0.long longshould be used because according to https://en.cppreference.com/w/cpp/chrono/durationstd::chrono::nanosecondstakes a type of at least 64 bits.Example of the problem here:
https://godbolt.org/z/o51G6xbqo
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(example:)
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-neededdoc(Your PR contains doc changes)
doc-complete(Docs have been already added)