Add type annotations for enum parameters in methods #169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds type annotations for enum parameters in various methods in the
pulsar-client-python
package. The goal of these changes is to improve the clarity and readability of the code, and to provide better hints to developers about the expected types of the parameters.Modifications
The following methods have been modified to include type annotations for their enum parameters:
Client.create_producer
Client.subscribe
Client.create_reader
For example, in the
Client.create_producer
method, thecompression_type
parameter was previously defined ascompression_type=CompressionType.NONE
, but now it is defined ascompression_type: CompressionType = CompressionType.NONE
.Benefits
The addition of these type annotations will make the code easier to read and understand. It will also provide better hints to developers about the expected types of the parameters, which could help prevent bugs and errors.
Please review and provide feedback.