-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add loadBalancerClass for proxy and pulsar-manager #546
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, small typo fixes suggested
k8s docs for loadBalancerClass: https://kubernetes.io/docs/concepts/services-networking/service/#load-balancer-class |
Hello, @lhotari thanks for fix. Possible to have a 3.7.1 with this improvement ? |
@lenglet-k There's some overhead in the Apache release process so I'd rather batch more changes in the next release. In Apache Software Foundation (ASF), there are some policies around releases and that's why it cannot happen purely by automation and it requires release voting. |
Fixes #545
Motivation
Add loadBalancerClass for use metallb loadbalancer service on private kubernetes cluster
Modifications
Add loadbalancerClass on proxy-service.yaml and pulsar-manager-service.yaml
Verifying this change