Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add loadBalancerClass for proxy and pulsar-manager #546

Merged
merged 4 commits into from
Nov 8, 2024

Conversation

lenglet-k
Copy link
Contributor

@lenglet-k lenglet-k commented Nov 7, 2024

Fixes #545

Motivation

Add loadBalancerClass for use metallb loadbalancer service on private kubernetes cluster

Modifications

Add loadbalancerClass on proxy-service.yaml and pulsar-manager-service.yaml

Verifying this change

  • Make sure that the change passes the CI checks.

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small typo fixes suggested

@lhotari
Copy link
Member

lhotari commented Nov 8, 2024

@lhotari lhotari merged commit ed50c68 into apache:master Nov 8, 2024
30 checks passed
@lenglet-k
Copy link
Contributor Author

Hello, @lhotari thanks for fix. Possible to have a 3.7.1 with this improvement ?

@lhotari
Copy link
Member

lhotari commented Nov 12, 2024

Hello, @lhotari thanks for fix. Possible to have a 3.7.1 with this improvement ?

@lenglet-k There's some overhead in the Apache release process so I'd rather batch more changes in the next release. In Apache Software Foundation (ASF), there are some policies around releases and that's why it cannot happen purely by automation and it requires release voting.
On your end, it's worth using a fork of the helm chart for your deployments so that you don't have to wait for upstream releases of the Apache Pulsar helm chart in order to start using some improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add loadBalancerClass for proxy and pulsar-manager
2 participants