Adding https support for backend service #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurleen-gks
force-pushed
the
https
branch
2 times, most recently
from
e2cad9a to
f460815
Compare
rdhabalia
reviewed
Sep 2, 2022
| @@ -124,13 +129,22 @@ private void scheduleCollectStats() { | |||
| clusterLists.forEach((clusterMap) -> { | |||
| String cluster = (String) clusterMap.get("cluster"); | |||
| Pair<String, String> envCluster = Pair.of(env.getName(), cluster); | |||
| String webServiceUrl = (String) clusterMap.get("serviceUrl"); | |||
|
|
|||
| String webServiceUrl = (String) (tlsEnabled && clusterMap.containsKey("serviceUrlTls") && StringUtils.isNotBlank((String) clusterMap.get("serviceUrlTls")) ? | |||
There was a problem hiding this comment.
String serviceUrlTls = clusterMap.get("serviceUrlTls");
tlsEnabled = tlsEnabled && StringUtils.isNotBlank(serviceUrlTls);
String webServiceUrl = tlsEnabled ? serviceUrlTls : clusterMap.get("serviceUrl");
at line#140
if(!url.startsWith("http") {
url = (tlsEnabled ? "https://" : "http://") + url;
}
we can remove line#144
|
We can check the schema of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
With tls enabled, admin instance was getting created with the wrong URL, leading to a 401 error for all the requests from the manager backend service
Manager log
Create Pulsar Admin instance. url=http://localhost:8080/, authPlugin=org.apache.pulsar.client.impl.auth.AuthenticationTls, authParams=tlsCertFile:client-cert.pem,tlsKeyFile:client-key.pem, tlsAllowInsecureConnection=false, tlsTrustCertsFilePath=cacert.pem, tlsEnableHostnameVerification=falseBroker log
2022-08-26T00:29:55,864-0700 [pulsar-web-42-22] INFO org.apache.pulsar.broker.PulsarService - created admin with url http://localhost:8080/Modifications