Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][website] exclude outdated versions of api documentation from search engine results #623

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

zuobiao-zhou
Copy link
Member

@zuobiao-zhou zuobiao-zhou commented Jun 28, 2023

This PR fixes apache/pulsar#20390

improved version of #591

cc @Anonymitaet @tisonkun

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@zuobiao-zhou
Copy link
Member Author

zuobiao-zhou commented Jun 28, 2023

image

@zuobiao-zhou
Copy link
Member Author

zuobiao-zhou commented Jun 28, 2023

Alternatively, it can be simplified to

Disallow: /api/*/2.*/

I'm unsure which approach is more suitable.

@Anonymitaet
Copy link
Member

@tisonkun
Could you please help review this PR? Thank you!

Comment on lines 37 to 38
Disallow: /api/*/2.10.x/
Disallow: /api/*/2.11.x/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC 2.10 and 2.11 are still maintained. If so, we should allow these two versions.

cc @Anonymitaet

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Pending to merging...

@tisonkun tisonkun merged commit e0557ec into apache:main Jun 30, 2023
@tisonkun
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [site] Google/Bing searches return javadoc for version 2.4.2 specifically
3 participants