Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] [doc] add plugin name into the demo of debezium-postgres-source #648

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

poorbarcode
Copy link
Contributor

The config(Example of PostgreSQL -> Configuration) demo of debezium-postgres-source contains the prop plugin.name

截屏2023-07-20 16 42 53

But in the section Example of PostgreSQL -> Usage -> Start the Pulsar Debezium connector in local run mode using one of the following methods, the prop plugin.name is missing.

截屏2023-07-20 16 46 18
  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions github-actions bot added the doc Improvements or additions to documentation label Jul 20, 2023
@poorbarcode poorbarcode requested a review from nlu90 July 20, 2023 08:48
@poorbarcode poorbarcode self-assigned this Jul 20, 2023
@poorbarcode poorbarcode added this to the 3.1.0 milestone Jul 20, 2023
@Anonymitaet
Copy link
Member

Is plugin.name required?

@poorbarcode
Copy link
Contributor Author

@Anonymitaet

Is plugin.name required?

In the demo it should be. Because not setting this parameter will throw an exception no plugin installed.(I am not sure if pgoutput is a built-in plugin that doesn't require additional installation, so it doesn't throw errors)

@Anonymitaet
Copy link
Member

ping @shibd @nlu90 to review it, thanks!

@Anonymitaet Anonymitaet merged commit d623f02 into apache:main Jul 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants