-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][doc] SEO for Concepts and Architecture except Overview and Messaging #674
Conversation
cc @Anonymitaet |
@@ -78,18 +67,6 @@ A group of namespaces that have anti-affinity to each other. | |||
A lightweight Pulsar broker in which all components run in a single Java Virtual Machine (JVM) process. Standalone | |||
clusters can be run on a single machine and are useful for development purposes. | |||
|
|||
### Cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any background why we remove these terms?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we have included the definitions of certain terms in the Concepts and Architecture chapter, redundant terminology definitions would add to the maintenance complexity. Users can refer to this chapter when seeking the definitions of specific terms.
Perhaps we can place a link at the repeated term's location in "reference-terminology.md" as a substitute for those redundant definitions?
e.g.
Producer
See here.
On the other hand, for instance, when a user searches for "what is Pulsar brokers," we expect the result is https://pulsar.apache.org/docs/next/concepts-architecture-overview instead of https://pulsar.apache.org/docs/next/reference-terminology/. Repetitive definitions would disperse the weight of the expected page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's necessary to keep those items empty and add links in the reference-terminology.md because we want to navigate users to "concept" topics only on purpose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your explanation!
@@ -56,7 +57,7 @@ In a Pulsar instance: | |||
|
|||
## Configuration store | |||
|
|||
The configuration store maintains all the configurations of a Pulsar instance, such as clusters, tenants, namespaces, partitioned topic-related configurations, and so on. A Pulsar instance can have a single local cluster, multiple local clusters, or multiple cross-region clusters. Consequently, the configuration store can share the configurations across multiple clusters under a Pulsar instance. The configuration store can be deployed on a separate ZooKeeper cluster or deployed on an existing ZooKeeper cluster. | |||
The Configuration store is a ZooKeeper quorum that is used for configuration-specific tasks and it maintains all the configurations of a Pulsar instance, such as clusters, tenants, namespaces, partitioned topic-related configurations, and so on. A Pulsar instance can have a single local cluster, multiple local clusters, or multiple cross-region clusters. Consequently, the configuration store can share the configurations across multiple clusters under a Pulsar instance. The configuration store can be deployed on a separate ZooKeeper cluster or deployed on an existing ZooKeeper cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Configuration store is a ZooKeeper quorum that is used for configuration-specific tasks and it maintains all the configurations of a Pulsar instance, such as clusters, tenants, namespaces, partitioned topic-related configurations, and so on. A Pulsar instance can have a single local cluster, multiple local clusters, or multiple cross-region clusters. Consequently, the configuration store can share the configurations across multiple clusters under a Pulsar instance. The configuration store can be deployed on a separate ZooKeeper cluster or deployed on an existing ZooKeeper cluster. | |
The configuration store is a ZooKeeper quorum that is used for configuration-specific tasks and it maintains all the configurations of a Pulsar instance, such as clusters, tenants, namespaces, partitioned topic-related configurations, and so on. A Pulsar instance can have a single local cluster, multiple local clusters, or multiple cross-region clusters. Consequently, the configuration store can share the configurations across multiple clusters under a Pulsar instance. The configuration store can be deployed on a separate ZooKeeper cluster or deployed on an existing ZooKeeper cluster. |
Why capitalize "C"?
|
||
|
||
You can see an illustration of how brokers and bookies interact in the diagram below: | ||
|
||
![Brokers and bookies](/assets/broker-bookie.png) | ||
![Brokers and bookies in Pulsar](/assets/broker-bookie.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![Brokers and bookies in Pulsar](/assets/broker-bookie.png) | |
![Brokers and bookies in a Pulsar cluster](/assets/broker-bookie.png) |
@@ -144,13 +145,13 @@ Some important things to know about the Pulsar proxy: | |||
|
|||
## Service discovery | |||
|
|||
[Clients](concepts-clients.md) connecting to Pulsar brokers need to be able to communicate with an entire Pulsar instance using a single URL. | |||
Service discovery is a mechanism provided by Pulsar that enables connecting [clients](concepts-clients.md) to use just a single URL to interact with an entire Pulsar instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Service discovery is a mechanism provided by Pulsar that enables connecting [clients](concepts-clients.md) to use just a single URL to interact with an entire Pulsar instance. | |
Service discovery is a mechanism that enables connecting [clients](concepts-clients.md) to use just a single URL to interact with an entire Pulsar instance. |
docs/concepts-authentication.md
Outdated
@@ -2,6 +2,7 @@ | |||
id: concepts-authentication | |||
title: Authentication and Authorization | |||
sidebar_label: "Authentication and Authorization" | |||
description: Get a high level understanding of the concept of Authentication and Authorization in Pulsar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: Get a high level understanding of the concept of Authentication and Authorization in Pulsar. | |
description: Get a high-level understanding of authentication and authorization in Pulsar. |
Why capitalize "A"?
docs/concepts-clients.md
Outdated
2. Once the client library has the broker address, it creates a TCP connection (or reuses an existing connection from the pool) and authenticates it. Within this connection, the client and broker exchange binary commands from a custom protocol. At this point, the client sends a command to create producer/consumer to the broker, which will comply after having validated the authorization policy. | ||
1. The client attempts to determine the owner of the topic by sending an HTTP lookup request to the broker. | ||
|
||
The request could reach one of the active brokers which, by looking at the (cached) zookeeper metadata knows who is serving the topic or, in case nobody is serving it, tries to assign it to the least loaded broker. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The request could reach one of the active brokers which, by looking at the (cached) zookeeper metadata knows who is serving the topic or, in case nobody is serving it, tries to assign it to the least loaded broker. | |
The request could reach one of the active brokers which, by looking at the (cached) Zookeeper metadata knows who is serving the topic or, in case nobody is serving it, tries to assign it to the least loaded broker. |
docs/concepts-throttling.md
Outdated
@@ -64,7 +65,7 @@ The dispatch rate limits configured at multiple levels take effect simultaneousl | |||
|
|||
### Throttling approaches | |||
|
|||
The following table outlines multiple approaches to configure the dispatch rate limits at different levels. | |||
The following table outlines multiple throttling approaches to configure the dispatch rate limits at different levels. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following table outlines multiple throttling approaches to configure the dispatch rate limits at different levels. | |
You can use multiple throttling approaches to configure dispatch rate limits at different levels. |
docs/concepts-topic-compaction.md
Outdated
@@ -2,13 +2,14 @@ | |||
id: concepts-topic-compaction | |||
title: Topic Compaction | |||
sidebar_label: "Topic Compaction" | |||
descriptions: Get a comprehensive understanding of the concept, features and functioning of topic compaction in Apache Pulsar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
descriptions: Get a comprehensive understanding of the concept, features and functioning of topic compaction in Apache Pulsar. | |
descriptions: Get a comprehensive understanding of concepts, features, and workflow of topic compaction in Apache Pulsar. |
docs/concepts-topic-compaction.md
Outdated
* Read beginning at the compaction horizon (if the message ID is lower than the compaction horizon) | ||
2. After that, the broker will create a new [BookKeeper ledger](concepts-architecture-overview.md#ledgers) and make a second iteration through each message on the topic. For each message: | ||
|
||
- if the key matches the latest occurrence of that key, then the key's data payload, message ID, and metadata will be written to the newly created ledger. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- if the key matches the latest occurrence of that key, then the key's data payload, message ID, and metadata will be written to the newly created ledger. | |
- If the key matches the latest occurrence of that key, then the key's data payload, message ID, and metadata will be written to the newly created ledger. |
docs/concepts-topic-compaction.md
Outdated
- the ID of the BookKeeper ledger | ||
- the message ID of the last compacted message (this is known as the **compaction horizon** of the topic). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
docs/tutorials-tenant.md
Outdated
@@ -5,7 +5,7 @@ sidebar_label: "Set up a tenant" | |||
--- | |||
|
|||
|
|||
Pulsar is a powerful messaging system you can use to process and route high volumes of data. Each tenant provides a distinct unit of isolation with its own set of roles, permissions, configuration settings, and bookmarks. | |||
Pulsar is a powerful messaging system you can use to process and route high volumes of data. Each t[enant](concepts-multi-tenancy.md#tenants) provides a distinct unit of isolation with its own set of roles, permissions, configuration settings, and bookmarks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulsar is a powerful messaging system you can use to process and route high volumes of data. Each t[enant](concepts-multi-tenancy.md#tenants) provides a distinct unit of isolation with its own set of roles, permissions, configuration settings, and bookmarks. | |
Pulsar is a powerful messaging system you can use to process and route high volumes of data. Each [tenant](concepts-multi-tenancy.md#tenants) provides a distinct unit of isolation with its own set of roles, permissions, configuration settings, and bookmarks. | |
Suggest updating the PR title to reflect the actual changes made in this PR. |
fixed, PTAL @Anonymitaet |
This PR do SEO for Concepts and Architecture.
doc
doc-required
doc-not-needed
doc-complete