Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEO for Adaptors #698

Merged
merged 1 commit into from
Sep 10, 2023
Merged

SEO for Adaptors #698

merged 1 commit into from
Sep 10, 2023

Conversation

zuobiao-zhou
Copy link
Member

This PR do SEO for Adaptors

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

image
image
image

@github-actions github-actions bot added the doc Improvements or additions to documentation label Sep 6, 2023
@zuobiao-zhou
Copy link
Member Author

PTAL @Anonymitaet TIA.

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tisonkun tisonkun merged commit 44723a1 into apache:main Sep 10, 2023
3 checks passed
@@ -10,7 +11,7 @@ An application can inject data into a Storm topology via a generic Pulsar spout,

## Using the Pulsar Storm Adaptor

Include dependency for Pulsar Storm Adaptor:
To use the Pulsar Storm Adaptor, you need to include dependency for Pulsar Storm Adaptor:

```xml
<dependency>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of thread, @cbornet is the GAV of pulsar storm adaptor changed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is "GAV" ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

group id, artifact id, version; that is, a unique identifier for a dependency.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok. The storm adapter has moved to the Storm project so we should update the doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants