Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve]Improve batching message doc #878

Merged
merged 9 commits into from
Oct 31, 2024

Conversation

dao-jun
Copy link
Member

@dao-jun dao-jun commented Apr 5, 2024

Improve the batching message doc

Fixes: apache/pulsar#22439

✅ Contribution Checklist

@dao-jun
Copy link
Member Author

dao-jun commented Apr 5, 2024

image

@dao-jun dao-jun self-assigned this Apr 5, 2024
@dao-jun dao-jun marked this pull request as draft April 5, 2024 13:18
@dao-jun dao-jun marked this pull request as ready for review April 5, 2024 13:29
@dao-jun dao-jun requested a review from lhotari April 5, 2024 13:29
docs/concepts-messaging.md Outdated Show resolved Hide resolved
docs/concepts-messaging.md Outdated Show resolved Hide resolved
@lhotari
Copy link
Member

lhotari commented Apr 5, 2024

Fixes: apache/pulsar#22439

I don't think that the documentation alone is a sufficient resolution. The Javadoc of the Pulsar Java client needs to be updated too.

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revisited this PR, merging

@lhotari lhotari merged commit 039ffb3 into apache:main Oct 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Producer batching is not working with synchronous mode using send api
2 participants