Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add key_shared advice to Cumulative Ack note #895

Merged
merged 3 commits into from
May 10, 2024

Conversation

AlvaroStream
Copy link
Contributor

Solves apache/pulsar/issues/22691

✅ Contribution Checklist

@visortelle
Copy link
Member

@AlvaroStream could you please make edits for v3.2.x as well? It's actively supported for 3 next months.

Screenshot 2024-05-10 at 1 31 08 PM

https://pulsar.apache.org/contribute/release-policy/#supported-versions

Copy link
Member

@RobertIndie RobertIndie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlvaroStream
Copy link
Contributor Author

Sorry I forgot to do the fetch upstream and missed the new directory.

Done now

@visortelle visortelle merged commit 02a9905 into apache:main May 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants