Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in concepts-broker-load-balancing-quick-start.md #940

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

zhouyifan279
Copy link
Contributor

@zhouyifan279 zhouyifan279 commented Jul 11, 2024

Changes

  1. Add a line separator in Segment Configure broker load balancer to run automatically - Step 4.2

Before change:

bin/pulsar-admin tenants create my-tenant-1 
bin/pulsar-admin namespaces create my-tenant-1/my-namespace-1 --bundles 1 bin/pulsar-admin topics create-partitioned-topic persistent://my-tenant-1/my-namespace-1/my-topic-1 -p 2000

After change:

bin/pulsar-admin tenants create my-tenant-1
bin/pulsar-admin namespaces create my-tenant-1/my-namespace-1 --bundles 1
bin/pulsar-admin topics create-partitioned-topic persistent://my-tenant-1/my-namespace-1/my-topic-1 -p 2000
  1. Fix typos in Segment Configure broker load balancer to run manually - Step 4.2
  • public/default/0x00000000_0x8000000 -> public/default/0x00000000_0x08000000
  • bin/pulsar-admin namespaces split-bundle --bundle 0x00000000_0x10000000 public/default -> bin/pulsar-admin namespaces split-bundle --bundle 0x00000000_0x08000000 public/default
  1. Other changes are introduced by rules defined in .editorconfig. I think it's better to keep them, although they add distractions for review.

✅ Contribution Checklist

@zhouyifan279
Copy link
Contributor Author

@nodece Can you please review this PR ? Thanks in advance.

Copy link
Member

@nodece nodece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@nodece nodece requested a review from lhotari July 12, 2024 08:33
@tisonkun tisonkun merged commit da4cd09 into apache:main Jul 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants