-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker]PIP-255 Add topic metrics for the number of production data requests to add a topic and the average number of messages per request. #20048
base: master
Are you sure you want to change the base?
Conversation
… topic and the average number of messages per request.
… topic and the average number of messages per request.
/pulsarbot run-failure-checks |
… topic and the average number of messages per request.
The pr had no activity for 30 days, mark with Stale label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did this PIP vote pass? Where is the issue?
PIP-255 is Make the partition assignment strategy pluggable
#19806
PIP must have an issue, right? |
pip needs to be discussed in the dev mail list, and finally initiate a vote, at least 2 PMC +1 can pass |
Do I still need to send an email to the development mailing list? |
The pr had no activity for 30 days, mark with Stale label. |
mail list:https://lists.apache.org/thread/w4jrs57gx69xw28psn0lnzxxtxnmrllo |
Motivation
In the current topic level monitoring, there is no metrics to monitor the number of send data requests and the number of messages per send request (i.e., each entry) for a topic. This is inconvenient for us to troubleshoot the following issues:
In cases where the client does not perform batch data writing or the batch written messages are not very reasonable, we cannot intuitively reflect through monitoring and cannot detect unreasonable business usage in a timely manner; It has a significant impact on production and consumption performance, increasing cluster load, reducing cluster performance, and increasing overall costs;
When we enable the production flow limiting strategy, if the flow limiting condition is triggered by the number of requests on a single connection, it is difficult to accurately locate which topic's high-frequency send data is causing it;
Modifications
Add four metrics:
pulsar_request_rate_in
: Topic send request rate.pulsar_average_msg_per_request
: Average number of messages per send request for topic.pulsar_producer_request_in
: producer send request rate.pulsar_producer_avg_msg_per_request
: Average number of messages per send request for producer.Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: yyj8#6