Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker]PIP-255 Add topic metrics for the number of production data requests to add a topic and the average number of messages per request. #20048

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

yyj8
Copy link
Contributor

@yyj8 yyj8 commented Apr 8, 2023

Motivation

In the current topic level monitoring, there is no metrics to monitor the number of send data requests and the number of messages per send request (i.e., each entry) for a topic. This is inconvenient for us to troubleshoot the following issues:

  1. In cases where the client does not perform batch data writing or the batch written messages are not very reasonable, we cannot intuitively reflect through monitoring and cannot detect unreasonable business usage in a timely manner; It has a significant impact on production and consumption performance, increasing cluster load, reducing cluster performance, and increasing overall costs;

  2. When we enable the production flow limiting strategy, if the flow limiting condition is triggered by the number of requests on a single connection, it is difficult to accurately locate which topic's high-frequency send data is causing it;

Modifications

Add four metrics:
pulsar_request_rate_in: Topic send request rate.
pulsar_average_msg_per_request: Average number of messages per send request for topic.

pulsar_producer_request_in: producer send request rate.
pulsar_producer_avg_msg_per_request: Average number of messages per send request for producer.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: yyj8#6

yyj8 added 2 commits April 8, 2023 19:49
… topic and the average number of messages per request.
… topic and the average number of messages per request.
@github-actions github-actions bot added the doc-required Your PR changes impact docs and you will update later. label Apr 8, 2023
@yyj8
Copy link
Contributor Author

yyj8 commented Apr 9, 2023

/pulsarbot run-failure-checks

… topic and the average number of messages per request.
@github-actions
Copy link

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label Jun 13, 2023
Copy link
Contributor

@315157973 315157973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this PIP vote pass? Where is the issue?

PIP-255 is Make the partition assignment strategy pluggable #19806

@yyj8
Copy link
Contributor Author

yyj8 commented Jul 5, 2023

Did this PIP vote pass? Where is the issue?

PIP-255 is Make the partition assignment strategy pluggable #19806

PIP must have an issue, right?

@github-actions github-actions bot removed the Stale label Jul 6, 2023
@315157973
Copy link
Contributor

Did this PIP vote pass? Where is the issue?
PIP-255 is Make the partition assignment strategy pluggable #19806

PIP must have an issue, right?

pip needs to be discussed in the dev mail list, and finally initiate a vote, at least 2 PMC +1 can pass

@yyj8
Copy link
Contributor Author

yyj8 commented Jul 14, 2023

Did this PIP vote pass? Where is the issue?
PIP-255 is Make the partition assignment strategy pluggable #19806

PIP must have an issue, right?

pip needs to be discussed in the dev mail list, and finally initiate a vote, at least 2 PMC +1 can pass

Do I still need to send an email to the development mailing list?

@Technoboy- Technoboy- added this to the 3.2.0 milestone Jul 31, 2023
@github-actions
Copy link

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label Aug 31, 2023
@Technoboy- Technoboy- modified the milestones: 3.2.0, 3.3.0 Dec 22, 2023
@yyj8
Copy link
Contributor Author

yyj8 commented Jan 4, 2024

Did this PIP vote pass? Where is the issue?
PIP-255 is Make the partition assignment strategy pluggable #19806

PIP must have an issue, right?

pip needs to be discussed in the dev mail list, and finally initiate a vote, at least 2 PMC +1 can pass

mail list:https://lists.apache.org/thread/w4jrs57gx69xw28psn0lnzxxtxnmrllo

@yyj8 yyj8 requested a review from 315157973 January 4, 2024 11:44
@coderzc coderzc modified the milestones: 3.3.0, 3.4.0 May 8, 2024
@tisonkun tisonkun removed their request for review May 9, 2024 00:28
@lhotari lhotari modified the milestones: 4.0.0, 4.1.0 Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required Your PR changes impact docs and you will update later. Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants