Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat][broker] PIP-264: Add OpenTelemetry metadata store stats #22952

Merged

Conversation

dragosvictor
Copy link
Contributor

@dragosvictor dragosvictor commented Jun 21, 2024

PIP-264

Motivation

Adds existing metadata store metrics (documented by https://pulsar.apache.org/docs/next/reference-metrics/#metadata-store-metrics) to the OpenTelemetry pipeline.

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • Added metric test in org.apache.pulsar.broker.stats.OpenTelemetryMetadataStoreStatsTest

Does this pull request potentially affect one of the following parts:

Documentation

Matching PR in forked repository

PR in forked repository: dragosvictor#36

@github-actions github-actions bot added the doc-required Your PR changes impact docs and you will update later. label Jun 21, 2024
@dragosvictor dragosvictor marked this pull request as ready for review June 21, 2024 01:06
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari lhotari merged commit 243ad5a into apache:master Jun 26, 2024
49 of 53 checks passed
@dragosvictor dragosvictor deleted the dmisca-pip-264-metadata-store-stats branch June 26, 2024 17:08
shibd added a commit to shibd/pulsar that referenced this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required Your PR changes impact docs and you will update later.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants