Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat][broker] PIP-264: Add OpenTelemetry broker replicator metrics #22972

Merged
merged 54 commits into from
Jun 25, 2024
Merged

[feat][broker] PIP-264: Add OpenTelemetry broker replicator metrics #22972

merged 54 commits into from
Jun 25, 2024

Commits on Apr 11, 2024

  1. Add Replicator stats draft

    @dragosvictor
    dragosvictor committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    3834f50 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Dummy commit

    @dragosvictor
    dragosvictor committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    5297854 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Merge remote-tracking branch 'origin/master' into pip-264-replication… 

    …-metrics
    @dragosvictor
    dragosvictor committed May 22, 2024
    Configuration menu
    Copy the full SHA
    f1ca793 View commit details
    Browse the repository at this point in the history

  2. Fix NPE bug in [Non]PersistentReplicator.getStats

    @dragosvictor
    dragosvictor committed May 22, 2024
    Configuration menu
    Copy the full SHA
    7642b8b View commit details
    Browse the repository at this point in the history

  3. Add Replicator.getTopic method

    @dragosvictor
    dragosvictor committed May 22, 2024
    Configuration menu
    Copy the full SHA
    37759a9 View commit details
    Browse the repository at this point in the history

  4. Checkstyle fix

    @dragosvictor
    dragosvictor committed May 22, 2024
    Configuration menu
    Copy the full SHA
    8dc58e8 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Factor out AbstractReplicator.getReplicationDelayMs

    @dragosvictor
    dragosvictor committed May 23, 2024
    Configuration menu
    Copy the full SHA
    a063034 View commit details
    Browse the repository at this point in the history

  2. Factor out AbstractReplicator.isConnected

    @dragosvictor
    dragosvictor committed May 23, 2024
    Configuration menu
    Copy the full SHA
    012cb1f View commit details
    Browse the repository at this point in the history

  3. Refactor ReplicatorStats

    @dragosvictor
    dragosvictor committed May 23, 2024
    Configuration menu
    Copy the full SHA
    5f056fa View commit details
    Browse the repository at this point in the history

  4. Fix possible NPEs in PersistentReplicator.updateCursorState

    @dragosvictor
    dragosvictor committed May 23, 2024
    Configuration menu
    Copy the full SHA
    1132518 View commit details
    Browse the repository at this point in the history

  5. Rename Replicator.getTopic to Replicator.getLocalTopic

    @dragosvictor
    dragosvictor committed May 23, 2024
    Configuration menu
    Copy the full SHA
    1fea1ac View commit details
    Browse the repository at this point in the history

  6. Instantiate OpenTelemetryReplicatorStats field in PulsarService

    @dragosvictor
    dragosvictor committed May 23, 2024
    Configuration menu
    Copy the full SHA
    4d85952 View commit details
    Browse the repository at this point in the history

  7. Enable OpenTelemetry in ReplicatorTest

    @dragosvictor
    dragosvictor committed May 23, 2024
    Configuration menu
    Copy the full SHA
    7540e9e View commit details
    Browse the repository at this point in the history

  8. Update ReplicatorStats implementation

    @dragosvictor
    dragosvictor committed May 23, 2024
    Configuration menu
    Copy the full SHA
    b6a30fd View commit details
    Browse the repository at this point in the history

  9. Update stat values

    @dragosvictor
    dragosvictor committed May 23, 2024
    Configuration menu
    Copy the full SHA
    4ef7ee7 View commit details
    Browse the repository at this point in the history

  10. Add draft OpenTelemetryReplicatorStatsTest

    @dragosvictor
    dragosvictor committed May 23, 2024
    Configuration menu
    Copy the full SHA
    ebbe49e View commit details
    Browse the repository at this point in the history

  11. Merge remote-tracking branch 'origin/master' into pip-264-replication… 

    …-metrics
    @dragosvictor
    dragosvictor committed May 23, 2024
    Configuration menu
    Copy the full SHA
    b505a28 View commit details
    Browse the repository at this point in the history

  12. Remove redundant cursor null pointer checks in PersistentReplicator

    @dragosvictor
    dragosvictor committed May 23, 2024
    Configuration menu
    Copy the full SHA
    154f0bc View commit details
    Browse the repository at this point in the history

  13. Checkstyle fix

    @dragosvictor
    dragosvictor committed May 23, 2024
    Configuration menu
    Copy the full SHA
    36d5d2c View commit details
    Browse the repository at this point in the history

  14. Update stats access

    @dragosvictor
    dragosvictor committed May 23, 2024
    Configuration menu
    Copy the full SHA
    23e24a2 View commit details
    Browse the repository at this point in the history

  15. Skip redundant null check

    @dragosvictor
    dragosvictor committed May 23, 2024
    Configuration menu
    Copy the full SHA
    6173af8 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Debug

    @dragosvictor
    dragosvictor committed May 24, 2024
    Configuration menu
    Copy the full SHA
    325ffca View commit details
    Browse the repository at this point in the history

  2. Debug

    @dragosvictor
    dragosvictor committed May 24, 2024
    Configuration menu
    Copy the full SHA
    b008ade View commit details
    Browse the repository at this point in the history

  3. Aadd default implementations for ReplicatorStats methods

    @dragosvictor
    dragosvictor committed May 24, 2024
    Configuration menu
    Copy the full SHA
    6af06f9 View commit details
    Browse the repository at this point in the history

  4. Fix test errors caused by stats serialization

    @dragosvictor
    dragosvictor committed May 24, 2024
    Configuration menu
    Copy the full SHA
    ed9be19 View commit details
    Browse the repository at this point in the history

  5. Spotbugs fixes

    @dragosvictor
    dragosvictor committed May 24, 2024
    Configuration menu
    Copy the full SHA
    2f71eb0 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Merge remote-tracking branch 'origin/master' into pip-264-replication… 

    …-metrics
    @dragosvictor
    dragosvictor committed May 28, 2024
    Configuration menu
    Copy the full SHA
    47c8617 View commit details
    Browse the repository at this point in the history

  2. Fix BrokerServiceLookupTest.testMultipleBrokerLookup

    @dragosvictor
    dragosvictor committed May 28, 2024
    Configuration menu
    Copy the full SHA
    5d20675 View commit details
    Browse the repository at this point in the history

  3. Add comments

    @dragosvictor
    dragosvictor committed May 28, 2024
    Configuration menu
    Copy the full SHA
    2b2d18d View commit details
    Browse the repository at this point in the history

  4. Add replicator stats attributes

    @dragosvictor
    dragosvictor committed May 28, 2024
    Configuration menu
    Copy the full SHA
    1228a03 View commit details
    Browse the repository at this point in the history

  5. Draft ReplicatorTest#testReplicationMetrics

    @dragosvictor
    dragosvictor committed May 28, 2024
    Configuration menu
    Copy the full SHA
    410d31e View commit details
    Browse the repository at this point in the history

  6. Fix test

    @dragosvictor
    dragosvictor committed May 28, 2024
    Configuration menu
    Copy the full SHA
    2b25472 View commit details
    Browse the repository at this point in the history

  7. Test fix

    @dragosvictor
    dragosvictor committed May 28, 2024
    Configuration menu
    Copy the full SHA
    5abbae3 View commit details
    Browse the repository at this point in the history

  8. Validate backlog counter

    @dragosvictor
    dragosvictor committed May 28, 2024
    Configuration menu
    Copy the full SHA
    e1b1d0e View commit details
    Browse the repository at this point in the history

  9. Implement dropped message counter

    @dragosvictor
    dragosvictor committed May 28, 2024
    Configuration menu
    Copy the full SHA
    a5789a4 View commit details
    Browse the repository at this point in the history

  10. Validate delay metric

    @dragosvictor
    dragosvictor committed May 28, 2024
    Configuration menu
    Copy the full SHA
    95aac51 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Validate expired metric

    @dragosvictor
    dragosvictor committed May 29, 2024
    Configuration menu
    Copy the full SHA
    1b8739e View commit details
    Browse the repository at this point in the history

  2. Test cleanup

    @dragosvictor
    dragosvictor committed May 29, 2024
    Configuration menu
    Copy the full SHA
    ad49a82 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into pip-264-replication… 

    …-metrics
    @dragosvictor
    dragosvictor committed May 29, 2024
    Configuration menu
    Copy the full SHA
    34e3fe8 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Merge remote-tracking branch 'origin/master' into pip-264-replication… 

    …-metrics
    @dragosvictor
    dragosvictor committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    03a7dd5 View commit details
    Browse the repository at this point in the history

  2. Cosmetic fixes

    @dragosvictor
    dragosvictor committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    ee03759 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into pip-264-replication… 

    …-metrics
    @dragosvictor
    dragosvictor committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    8168cd2 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Merge remote-tracking branch 'origin/master' into pip-264-replication… 

    …-metrics
    @dragosvictor
    dragosvictor committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    c3fc519 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2024

  1. Merge remote-tracking branch 'origin/master' into pip-264-replication… 

    …-metrics
    @dragosvictor
    dragosvictor committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    92354e9 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Merge remote-tracking branch 'origin/master' into pip-264-replication… 

    …-metrics
    @dragosvictor
    dragosvictor committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    7469faf View commit details
    Browse the repository at this point in the history

  2. Fix merge conflicts

    @dragosvictor
    dragosvictor committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    92f7ce8 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Merge remote-tracking branch 'origin/master' into pip-264-replication… 

    …-metrics
    @dragosvictor
    dragosvictor committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    a08b692 View commit details
    Browse the repository at this point in the history

  2. Rename Replicator.getStats -> Replicator.computeStats for improved cl… 

    …arity
    @dragosvictor
    dragosvictor committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    7390e07 View commit details
    Browse the repository at this point in the history

  3. Increment replicator message publish counters

    @dragosvictor
    dragosvictor committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    94c40d9 View commit details
    Browse the repository at this point in the history

  4. Skip exceptional topic futures during otel collections

    @dragosvictor
    dragosvictor committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    58b0c81 View commit details
    Browse the repository at this point in the history

  5. Cache attributes object in AbstractReplicator field

    @dragosvictor
    dragosvictor committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    0b8c93a View commit details
    Browse the repository at this point in the history

  6. Update ReplicatorTest#testReplicationMetrics

    @dragosvictor
    dragosvictor committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    bea5073 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Remove hardcoded pulsar.broker.replication.connected.count metric

    @dragosvictor
    dragosvictor committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    9a9c35a View commit details
    Browse the repository at this point in the history

  2. Cosmetic fixes

    @dragosvictor
    dragosvictor committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    2a8534a View commit details
    Browse the repository at this point in the history