-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat][misc] PIP-264: Add OpenTelemetry authentication and token metrics #23016
Merged
lhotari
merged 32 commits into
apache:master
from
dragosvictor:dmisca-pip-264-authentication-metrics
Aug 29, 2024
Merged
[feat][misc] PIP-264: Add OpenTelemetry authentication and token metrics #23016
lhotari
merged 32 commits into
apache:master
from
dragosvictor:dmisca-pip-264-authentication-metrics
Aug 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entication-metrics
…entication-metrics
…entication-metrics
github-actions
bot
added
the
doc-required
Your PR changes impact docs and you will update later.
label
Jul 9, 2024
lhotari
reviewed
Jul 9, 2024
...common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderBase.java
Outdated
Show resolved
Hide resolved
dragosvictor
force-pushed
the
dmisca-pip-264-authentication-metrics
branch
from
July 9, 2024 17:47
0758b2f
to
c947325
Compare
heesung-sn
reviewed
Jul 17, 2024
...rc/main/java/org/apache/pulsar/broker/authentication/metrics/AuthenticationMetricsToken.java
Outdated
Show resolved
Hide resolved
…entication-metrics
heesung-sn
approved these changes
Aug 28, 2024
...rc/main/java/org/apache/pulsar/broker/authentication/metrics/AuthenticationMetricsToken.java
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/PrometheusMetricsTest.java
Show resolved
Hide resolved
lhotari
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Good work @dragosvictor
/pulsarbot rerun-failure-checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIP-264
Motivation
Adds authentication and token metrics, as currently described here, to the OpenTelemetry pipeline.
Modifications
org.apache.pulsar.broker.authentication.AuthenticationProvider#initialize(org.apache.pulsar.broker.ServiceConfiguration, io.opentelemetry.api.OpenTelemetry)
, giving the authentication plugin access to the OpenTelemetry instance.org.apache.pulsar.broker.authentication.AuthenticationProviderBase
, used to initialize and maintain theAuthenticationMetrics
object. This class can be further used by the providers, simplifying development.AuthenticationMetrics.authenticateSuccess
Verifying this change
This change added tests and can be verified as follows:
org.apache.pulsar.broker.stats.OpenTelemetryAuthenticationStatsTest
covering the new metricsDoes this pull request potentially affect one of the following parts:
Documentation
doc
doc-required
[feat][doc] PIP-264: Add authentication and token metrics reference pulsar-site#937doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: dragosvictor#22