-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat][misc] PIP-264: Add OpenTelemetry messaging rate limit metrics #23035
Merged
heesung-sn
merged 12 commits into
apache:master
from
dragosvictor:dmisca-pip-264-inflight-reads-limiter-metrics
Jul 23, 2024
Merged
[feat][misc] PIP-264: Add OpenTelemetry messaging rate limit metrics #23035
heesung-sn
merged 12 commits into
apache:master
from
dragosvictor:dmisca-pip-264-inflight-reads-limiter-metrics
Jul 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debug ServerCnxThrottleTracker failures
github-actions
bot
added
the
doc-required
Your PR changes impact docs and you will update later.
label
Jul 16, 2024
heesung-sn
reviewed
Jul 17, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
Show resolved
Hide resolved
heesung-sn
reviewed
Jul 17, 2024
pulsar-opentelemetry/src/main/java/org/apache/pulsar/opentelemetry/OpenTelemetryAttributes.java
Show resolved
Hide resolved
heesung-sn
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIP-264
Motivation
Adds messaging rate limit metrics, currently exposed in classes
InflightReadsLimiter
andServerCnxThrottleTracker
, to the OpenTelemetry pipeline.Modifications
pulsar_broker_throttled_connections
. This gives better visibility into the frequency of rate limiting operations.Verifying this change
This change added tests and can be verified as follows:
InflightReadsLimiterTest#testDisabled
andInflightReadsLimiterTest#testBasicAcquireRelease
to cover the changes to theInflightReadsLimiter
metricsMessagePublishBufferThrottleTest
to verify connection pause/unpause metricsMessagePublishBufferThrottleTest#testConnectionThrottled
to verify connection throttle/unthrottle metricsDoes this pull request potentially affect one of the following parts:
Documentation
doc
doc-required
[feat][doc] PIP-264: Add OpenTelemetry messaging rate limit metrics reference pulsar-site#943doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: dragosvictor#41