[improve][broker] Optimize message payload traffic for ShadowReplicator #23236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Motivation Currently, the ShadowReplicator will sync all the message payload from the source topic to the shadow topic(ShadowManagedLedger). This increases traffic between brokers significantly. Actually, the ShadowManagedLedger only need the position information from this replicated message. It can get the payload from the Bookkeeper directly. The ShadowReplicator don't need to sync the message payload between the broker ## Modification - Prevent ShadowReplicator from syncing message payloads
RobertIndie
force-pushed
the
dont-replicate-shadow-payload
branch
from
46a8567
to
e4a7da5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23236 +/- ##
============================================
+ Coverage 73.57% 74.57% +0.99%
- Complexity 32624 33778 +1154
============================================
Files 1877 1926 +49
Lines 139502 145011 +5509
Branches 15299 15859 +560
============================================
+ Hits 102638 108136 +5498
+ Misses 28908 28608 -300
- Partials 7956 8267 +311
Flags with carried forward coverage won't be shown. Click here to find out more.
|
BewareMyPower
requested changes
Sep 2, 2024
...-broker/src/test/java/org/apache/pulsar/broker/service/persistent/ShadowTopicRealBkTest.java
Show resolved
Hide resolved
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpAddEntry.java
Show resolved
Hide resolved
...r-broker/src/test/java/org/apache/pulsar/broker/service/persistent/ShadowReplicatorTest.java
Outdated
Show resolved
Hide resolved
RobertIndie
force-pushed
the
dont-replicate-shadow-payload
branch
from
d60d5bb
to
0bafb35
Compare
BewareMyPower
approved these changes
Sep 5, 2024
BewareMyPower
added
type/enhancement
|
It looks like this would require #22972 changes for applying this cleanly to branch-3.3 . |
15 tasks
michalcukierman
pushed a commit
to michalcukierman/pulsar
that referenced
this pull request
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the ShadowReplicator syncs all message payloads from the source topic to the shadow topic (ShadowManagedLedger). This significantly increases traffic between brokers. However, the ShadowManagedLedger only requires the position information from these messages. It can retrieve the payload directly from the Bookkeeper. Therefore, the ShadowReplicator does not need to sync the message payloads between brokers.
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: RobertIndie#16