-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][test] Split tests module #23536
Open
heesung-sn
wants to merge
7
commits into
apache:master
Choose a base branch
from
heesung-sn:integ-test-reuse
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@heesung-sn Please add the following content to your PR description and select a checkbox:
|
heesung-sn
force-pushed
the
integ-test-reuse
branch
from
November 1, 2024 02:48
d56d61f
to
2cb5c2d
Compare
heesung-sn
force-pushed
the
integ-test-reuse
branch
from
November 1, 2024 03:06
2cb5c2d
to
f5991a8
Compare
heesung-sn
force-pushed
the
integ-test-reuse
branch
from
November 1, 2024 20:52
6214fe9
to
d86cf6c
Compare
heesung-sn
force-pushed
the
integ-test-reuse
branch
3 times, most recently
from
November 2, 2024 00:12
aa3d579
to
1cf0f6f
Compare
heesung-sn
force-pushed
the
integ-test-reuse
branch
from
November 2, 2024 00:39
1cf0f6f
to
e7369a9
Compare
github-actions
bot
added
doc-not-needed
Your PR changes do not impact docs
and removed
doc-label-missing
labels
Nov 2, 2024
heesung-sn
changed the title
[improve][tests] Split tests module
[improve][test] Split tests module
Nov 2, 2024
heesung-sn
force-pushed
the
integ-test-reuse
branch
from
November 2, 2024 04:38
a49bbcd
to
6889aaf
Compare
heesung-sn
force-pushed
the
integ-test-reuse
branch
from
November 12, 2024 17:39
9e110e3
to
dbc1a34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I think we can refactor/split the
tests
module(the integration testmodule) to reuse the integration test code better.
Currently, there are good test classes to reuse(such as topic message
test cases, container setup, and other test util funcs), but this
module is built under "test" scope only, making it hard to reuse in
other projects.
discussion thread: https://lists.apache.org/thread/fn3rk1x7v9291qh3g6vf4jxhvq6zc4mm
Modifications
I propose the following module structure.
tests
: contains actual integ test runners built under testscope(e.g. test-ng test classes, depending on
pulsar-inttest-lib,
pulsar-inttest-client` and other modules)pulsar-inttest-lib
: contains common test libraries(test-utils, testcontainers, and other sharable integ test setups)
pulsar-inttest-client
: contains common integ-test client cases (itshould contain only client side test logic, depending on PulsarClient
and PulsarAdmin). These test cases can be used in
tests
.Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: heesung-sn#86