Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][test] Split tests module #23536

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

heesung-sn
Copy link
Contributor

@heesung-sn heesung-sn commented Nov 1, 2024

Motivation

I think we can refactor/split the tests module(the integration test
module) to reuse the integration test code better.

Currently, there are good test classes to reuse(such as topic message
test cases, container setup, and other test util funcs), but this
module is built under "test" scope only, making it hard to reuse in
other projects.

discussion thread: https://lists.apache.org/thread/fn3rk1x7v9291qh3g6vf4jxhvq6zc4mm

Modifications

I propose the following module structure.

tests : contains actual integ test runners built under test
scope(e.g. test-ng test classes, depending on pulsar-inttest-lib, pulsar-inttest-client` and other modules)

pulsar-inttest-lib : contains common test libraries(test-utils, test
containers, and other sharable integ test setups)

pulsar-inttest-client : contains common integ-test client cases (it
should contain only client side test logic, depending on PulsarClient
and PulsarAdmin). These test cases can be used in tests.

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: heesung-sn#86

Copy link

github-actions bot commented Nov 1, 2024

@heesung-sn Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@heesung-sn heesung-sn force-pushed the integ-test-reuse branch 3 times, most recently from aa3d579 to 1cf0f6f Compare November 2, 2024 00:12
@heesung-sn heesung-sn changed the title refactor 1 [improve][tests] Split tests module Nov 2, 2024
@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Nov 2, 2024
@heesung-sn heesung-sn self-assigned this Nov 2, 2024
@heesung-sn heesung-sn changed the title [improve][tests] Split tests module [improve][test] Split tests module Nov 2, 2024
@heesung-sn heesung-sn added this to the 4.1.0 milestone Nov 2, 2024
@heesung-sn heesung-sn marked this pull request as ready for review November 2, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant