Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][test] Clarify method signatures in Bookkeeper mock client #23598

Merged
merged 1 commit into from
Nov 14, 2024
Merged

[improve][test] Clarify method signatures in Bookkeeper mock client #23598

merged 1 commit into from
Nov 14, 2024
+15 −15

Conversation

zzzk1
Copy link
Contributor

@zzzk1 zzzk1 commented Nov 13, 2024

Motivation

I read testmocks model codes, found some code namely maybe more clearly

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 13, 2024
lhotari
lhotari approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari lhotari added this to the 4.1.0 milestone Nov 13, 2024
@Technoboy- Technoboy- merged commit 0b0eef9 into apache:master Nov 14, 2024
54 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhotari lhotari lhotari approved these changes

Assignees

@zzzk1 zzzk1

Labels
doc-not-needed Your PR changes do not impact docs release/4.0.1
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@zzzk1 @lhotari @Technoboy-