Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] Add additional configuration items to control the type of auto-creation of retry-topic and DLQ-topic #23806

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zjxxzjwang
Copy link
Contributor

@zjxxzjwang zjxxzjwang commented Jan 3, 2025

Motivation

when the code logic automatically creates a try-topic or DLQ-topic, it only creates non-partitioned retry-topic and non-partitioned DLQ-topic, regardless of the value of the “allowAutoTopicCreationType” configuration.

Modifications

Depending on the value of the “allowAutoTopicCreationType” configuration item, control the type of auto-creation of a try-topic or DLQ-topic.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 3, 2025
@lhotari
Copy link
Member

lhotari commented Jan 3, 2025

@zjxxzjwang Please rename this PR. The current title is confusing.

Hint: using ChatGPT or some other LLM could help provide better names for PRs. LLMs are also useful in fixing grammar mistakes.

One way to pass the PR details to LLM is to append .patch to the url, for example https://github.com/apache/pulsar/pull/23806.patch and then store this in a file that is passed to an LLM. Also store the output of https://api.github.com/repos/apache/pulsar/pulls/23806 and pass that in a file. (Alternative is to print current PR page to PDF and also pass that.)
In the prompt "please provide a better title and description for this PR with fixed grammar and improved clarity. return the result in downloadable markdown format.".

Here's an example from Claude:
image

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that it's been an intentional change to create non-partitioned retry-topics and DLQ-topics. This change was made in PR #22705.
I guess we would need a separate configuration or namespace level policy for controlling the behavior. This type of decisions are made on the [email protected] mailing list and they are usually documented as PIPs.

…pe of auto-creation of retry-topic and DLQ-topic
@zjxxzjwang zjxxzjwang changed the title [improve][broker] Optimization only automatically creates non-partitioned retry-topic and DLQ-topic. [improve][broker] Add additional configuration items to control the type of auto-creation of retry-topic and DLQ-topic Jan 6, 2025
@zjxxzjwang zjxxzjwang requested a review from lhotari January 6, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants