-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][ci] Increase Maven max heap size to 2048M and tune GCLockerRetryAllocationCount #23883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
changed the title
[improve][ci] Increase Maven max heap size to 2048M in CI
[improve][ci] Increase Maven max heap size to 2048M and tune GCLockerRetryAllocationCount
Jan 23, 2025
nicoloboschi
approved these changes
Jan 23, 2025
nodece
approved these changes
Jan 23, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23883 +/- ##
============================================
+ Coverage 73.57% 74.22% +0.64%
+ Complexity 32624 31857 -767
============================================
Files 1877 1853 -24
Lines 139502 143619 +4117
Branches 15299 16311 +1012
============================================
+ Hits 102638 106598 +3960
+ Misses 28908 28660 -248
- Partials 7956 8361 +405
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/ci
cherry-picked/branch-3.0
cherry-picked/branch-3.3
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.10
release/3.3.5
release/4.0.3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In CI, "Build Pulsar docker image" fails sporadically:
Additional Context
The NiFi NAR plugin isn't optimal for Pulsar usage since it scans all dependencies for NiFi style documentation.
The excessive heap usage problem would most like be resolved by apache/nifi-maven#35 . However, the NiFi NAR plugin version including the change requires Java 21. One possibility would be to use a Maven profile activated when Java 21 is used to built Pulsar to use the newer version with the possibility to skip NiFI style documentation generation. That is out of scope for this PR.
Modifications
-XX:+UnlockDiagnosticVMOptions -XX:GCLockerRetryAllocationCount=100
Documentation
doc
doc-required
doc-not-needed
doc-complete