Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] Apply dispatcherMaxReadSizeBytes also for replay reads for Shared and Key_Shared subscriptions #23894

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Jan 24, 2025

Fixes #23505

Motivation

See #23505. It is expected that dispatcherMaxReadSizeBytes also limits replay queue reads. Replay reads are currently unbounded in byte size, which is unexpected behavior.

Modifications

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.16%. Comparing base (bbc6224) to head (6d65d41).
Report is 868 commits behind head on master.

Files with missing lines Patch % Lines
...sistent/PersistentDispatcherMultipleConsumers.java 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23894      +/-   ##
============================================
+ Coverage     73.57%   74.16%   +0.59%     
+ Complexity    32624    32212     -412     
============================================
  Files          1877     1854      -23     
  Lines        139502   143644    +4142     
  Branches      15299    16320    +1021     
============================================
+ Hits         102638   106539    +3901     
+ Misses        28908    28719     -189     
- Partials       7956     8386     +430     
Flag Coverage Δ
inttests 26.69% <42.85%> (+2.11%) ⬆️
systests 23.13% <28.57%> (-1.20%) ⬇️
unittests 73.69% <57.14%> (+0.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...sistent/PersistentDispatcherMultipleConsumers.java 74.38% <57.14%> (+0.05%) ⬆️

... and 1027 files with indirect coverage changes

@lhotari lhotari force-pushed the lh-limit-replay-messages-by-size branch from c8a23a0 to 6d65d41 Compare January 25, 2025 09:02
@lhotari
Copy link
Member Author

lhotari commented Jan 25, 2025

@heesung-sn This PR has been rebased now. Please review

@lhotari lhotari merged commit 11a615e into apache:master Jan 27, 2025
52 checks passed
lhotari added a commit that referenced this pull request Jan 27, 2025
…for Shared and Key_Shared subscriptions (#23894)

(cherry picked from commit 11a615e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants