Skip to content

Commit

Permalink
DISPATCH-2234: Update JavaScript console packages for the 1.19.0 rele…
Browse files Browse the repository at this point in the history
…ase (#1517)

* Error: A <Route> is only ever to be used as the child of <Routes> element, never rendered directly. Please wrap your <Route> in a <Routes>.
* Error: You cannot render a <Router> inside another <Router>. You should never have more than one in your app.

See https://reactrouter.com/docs/en/v6/upgrading/v5, and therein linked https://gist.github.com/mjackson/d54b40a094277b7afdd6b81f51a0393f

* BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
* Module not found: Error: Can't resolve 'os' in '/home/jdanek/repos/qpid/qpid-dispatch/console/react/node_modules/rhea/lib'
* facebook/create-react-app#11756
* downgraded and filled amqp/rhea#379
  • Loading branch information
jiridanek authored Feb 17, 2022
1 parent 4c8008b commit 25261f4
Show file tree
Hide file tree
Showing 11 changed files with 5,076 additions and 5,985 deletions.
10,747 changes: 4,910 additions & 5,837 deletions console/react/package-lock.json

Large diffs are not rendered by default.

38 changes: 19 additions & 19 deletions console/react/package.json
Original file line number Diff line number Diff line change
@@ -1,25 +1,25 @@
{
"name": "dispatch-console",
"version": "1.17.0",
"version": "1.19.0",
"private": true,
"dependencies": {
"@patternfly/patternfly": "^4.125.3",
"@patternfly/react-charts": "^6.15.14",
"@patternfly/react-core": "^4.147.0",
"@patternfly/react-icons": "^4.11.8",
"@patternfly/react-styles": "^4.11.8",
"@patternfly/react-table": "^4.29.37",
"@patternfly/react-topology": "^4.9.42",
"@patternfly/patternfly": "^4.171.1",
"@patternfly/react-charts": "^6.45.15",
"@patternfly/react-core": "^4.192.15",
"@patternfly/react-icons": "^4.43.15",
"@patternfly/react-styles": "^4.42.15",
"@patternfly/react-table": "^4.61.15",
"@patternfly/react-topology": "^4.39.15",
"d3": "^3.5.17",
"d3-queue": "^3.0.7",
"express": "^4.17.1",
"express": "^4.17.2",
"font-awesome": "^4.7.0",
"prop-types": "^15.7.2",
"prop-types": "^15.8.1",
"react": "^17.0.2",
"react-dom": "^17.0.2",
"react-fontawesome": "^1.7.1",
"react-router-dom": "^5.2.0",
"rhea": "^2.0.4",
"react-router-dom": "^6.2.1",
"rhea": "^3.0.0",
"topojson-client": "^3.1.0"
},
"scripts": {
Expand Down Expand Up @@ -59,14 +59,14 @@
},
"devDependencies": {
"@react-mock/localstorage": "^0.1.2",
"@testing-library/jest-dom": "^5.14.1",
"@testing-library/react": "^12.0.0",
"@types/jest": "^27.0.1",
"body-parser": "^1.19.0",
"browserslist": "^4.16.8",
"@testing-library/jest-dom": "^5.16.2",
"@testing-library/react": "^12.1.3",
"@types/jest": "^27.4.0",
"body-parser": "^1.19.2",
"browserslist": "^4.19.1",
"jest-axe": "^5.0.1",
"prettier": "^2.3.2",
"prettier": "^2.5.1",
"react-scripts": "^4.0.3",
"typescript": "^4.3.5"
"typescript": "^4.5.5"
}
}
41 changes: 19 additions & 22 deletions console/react/src/App.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@ specific language governing permissions and limitations
under the License.
*/

import React, { Component } from "react";
import { HashRouter as Router, Route } from "react-router-dom";
import React from "react";
import { unstable_HistoryRouter as HistoryRouter } from "react-router-dom";
import { createHashHistory } from "history";

import "@patternfly/patternfly/patternfly.css";
import "@patternfly/patternfly/patternfly-addons.css";
Expand All @@ -28,26 +29,22 @@ import "@patternfly/patternfly/components/Nav/nav.css";
import { QDRService } from "./common/qdrService";
import "./App.css";
import PageLayout from "./overview/dashboard/layout";
class App extends Component {
state = {};

render() {
// service is passed in to make testing easier
const service = new QDRService();
// also, a router is used here to provide PageLayout with a history property
return (
<Router>
<div className="App pf-m-redhat-font">
<Route
path="/"
render={props => (
<PageLayout service={service} {...props} config={this.props.config} />
)}
/>
</div>
</Router>
);
}

function App(props) {

// service is passed in to make testing easier
const service = new QDRService();

// also, a router is used here to provide PageLayout with a history property
const history = createHashHistory({ window });

return (
<HistoryRouter history={history}>
<div className="App pf-m-redhat-font">
<PageLayout service={service} {...props} history={history} config={props.config}/>
</div>
</HistoryRouter>
);
}

export default App;
4 changes: 2 additions & 2 deletions console/react/src/details/createTablePage.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ import {

import { cellWidth } from "@patternfly/react-table";
import { Card, CardBody } from "@patternfly/react-core";
import { Redirect } from "react-router-dom";
import { Navigate } from "react-router-dom";
import { dataMap as detailsDataMap, defaultData } from "./entityData";

class CreateTablePage extends React.Component {
Expand Down Expand Up @@ -263,7 +263,7 @@ class CreateTablePage extends React.Component {
render() {
if (this.state.redirect) {
return (
<Redirect
<Navigate
to={{
pathname: this.state.redirectPath,
state: this.state.redirectState
Expand Down
4 changes: 2 additions & 2 deletions console/react/src/details/detailsTablePage.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ import {
TableVariant
} from "@patternfly/react-table";
import { Card, CardBody } from "@patternfly/react-core";
import { Redirect } from "react-router-dom";
import { Navigate } from "react-router-dom";
import { dataMap } from "../overview/entityData";
import { dataMap as detailsDataMap, defaultData } from "./entityData";
import Updated from "../common/updated";
Expand Down Expand Up @@ -171,7 +171,7 @@ class DetailsTablePage extends React.Component {
render() {
if (this.state.redirect) {
return (
<Redirect
<Navigate
to={{
pathname: this.state.redirectPath,
state: this.state.redirectState
Expand Down
4 changes: 2 additions & 2 deletions console/react/src/details/entityListTable.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import {
TableVariant
} from "@patternfly/react-table";
import { Button, Pagination } from "@patternfly/react-core";
import { Redirect } from "react-router-dom";
import { Navigate } from "react-router-dom";
import TableToolbar from "../common/tableToolbar";
import { dataMap, defaultData } from "./entityData";
import EmptyTable from "./emptyTablePage";
Expand Down Expand Up @@ -402,7 +402,7 @@ class EntityListTable extends React.Component {

if (this.state.redirect) {
return (
<Redirect
<Navigate
to={{
pathname: this.dataSource.detailPath || "/details",
state: this.state.redirectState
Expand Down
4 changes: 2 additions & 2 deletions console/react/src/details/updateTablePage.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ import {

import { cellWidth } from "@patternfly/react-table";
import { Card, CardBody } from "@patternfly/react-core";
import { Redirect } from "react-router-dom";
import { Navigate } from "react-router-dom";
import { dataMap as detailsDataMap, defaultData } from "./entityData";
import { utils } from "../common/amqp/utilities";

Expand Down Expand Up @@ -270,7 +270,7 @@ class UpdateTablePage extends React.Component {
render() {
if (this.state.redirect) {
return (
<Redirect
<Navigate
to={{
pathname: this.state.redirectPath,
state: this.state.redirectState
Expand Down
Loading

0 comments on commit 25261f4

Please sign in to comment.