annoying mypy errors

apache · Dec 2, 2023 · 44dd9fa · 44dd9fa
1 parent 3e8b3d0
commit 44dd9fa
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/tests/http2_server.py b/tests/http2_server.py
@@ -22,14 +22,14 @@
 
 from quart import Quart, request
 try:
-    from quart.static import send_file  # noqa  # mypy#8823  # type: ignore[attr-defined]
+    from quart.static import send_file  # type: ignore[attr-defined]  # mypy#8823
 except ImportError:
-    from quart.helpers import send_file  # noqa  # mypy#8823  # type: ignore[attr-defined, no-redef]  # mypy#1153
+    from quart.helpers import send_file  # type: ignore[attr-defined, no-redef]  # mypy#1153
 
 try:
-    from quart.exceptions import HTTPStatusException  # noqa  # mypy#8823  # type: ignore[attr-defined]
+    from quart.exceptions import HTTPStatusException  # type: ignore[attr-defined]
 except ImportError:
-    from werkzeug.exceptions import InternalServerError as HTTPStatusException  # noqa  # mypy#8823  # type: ignore[no-redef]  # mypy#1153
+    from werkzeug.exceptions import InternalServerError as HTTPStatusException  # type: ignore[no-redef]  # mypy#1153
 
 app = Quart(__name__)
 

diff --git a/tests/system_tests_websockets.py b/tests/system_tests_websockets.py
@@ -23,7 +23,7 @@
 try:
     import websockets
 except ImportError:
-    websockets = None  # noqa  # type: ignore[assignment]  # expression has type "None", variable has type Module
+    websockets = None  # type: ignore[assignment]  # expression has type "None", variable has type Module
 
 from system_test import Qdrouterd
 from system_test import main_module, TestCase, Process

diff --git a/tests/tox.ini.in b/tests/tox.ini.in
@@ -217,7 +217,8 @@ disable =
 
 [mypy]
 warn_redundant_casts = True
-warn_unused_ignores = True
+# enable when wanting to clean up ignores
+# warn_unused_ignores = True
 
 # mypy cannot handle overridden attributes
 # https://github.com/python/mypy/issues/7505