RANGER-4942: Fix Dockerfiles of ./build_ranger_using_docker.sh #396
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes some syntactic mistakes on the Dockerfiles involved in the Ranger build in a Dockerized environment. The 3 main issues I have fixed are:
RUN if [ "${OS_NAME}" == "UBUNTU" ]; then ...
: the commands enclosed in this if-condition will never be executed because the shell used for this command is/bin/sh
, which requires a single=
for string comparison.For some reasons, the
ENV JAVA_HOME /usr/lib/...
Dockerfile command is placed inside theRUN
command. I put it before theRUN
command in order to use theJAVA_HOME
env variable in the shell script.Many env variables are initialized using the alternative syntax
ENV MY_ENV_VAR value1
, which is not compliant with the guidelines, that suggests usingENV MY_ENV_VAR=value1
. I quote from theENV
reference:I rewrote only some of them, in case you preferred another PR for a general Dockerfile/compose improvements.
How was this patch tested?
By running
./build_ranger_using_docker.sh