Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RATIS-2133. Include netty-proxy-handler dependency in the project. #53

Closed
wants to merge 1 commit into from

Conversation

sadanand48
Copy link

netty-proxy-handler artifact is required to handle cases where http proxy is configured in an application .

Currently it is excluded from the misc jar. This caused issues in Ozone -> https://issues.apache.org/jira/browse/HDDS-11257.

https://issues.apache.org/jira/browse/RATIS-2133

Before the fix:

misc % mvn help:effective-pom | grep "netty-handler-proxy"
        <artifactId>netty-handler-proxy</artifactId>
                  <exclude>io.netty:netty-handler-proxy</exclude>

After the fix

misc % mvn help:effective-pom | grep "netty-handler-proxy"
        <artifactId>netty-handler-proxy</artifactId>

@sadanand48
Copy link
Author

@adoroszlai, Could you please review?

@adoroszlai
Copy link
Contributor

Thanks @sadanand48 for the patch. Shouldn't Ratis avoid using proxy for gRPC/Netty? HTTP proxy is usually for accessing the "internet". All Ratis traffic going through the proxy will be a serious bottleneck.

CC @szetszwo

@sadanand48
Copy link
Author

Shouldn't Ratis avoid using proxy for gRPC/Netty? HTTP proxy is usually for accessing the "internet".

I'm not sure about the use case for http proxy for the detected error case. I can think of HttpFS where client wants to set up a proxy to route all requests through it. Is it a valid case? In this case how can we route only selective traffic through proxy

@adoroszlai
Copy link
Contributor

I mean we should change Ratis to ignore any HTTP proxy. It would apply to Ratis client-server traffic, and Ratis server-server traffic. It wouldn't affect traffic from HTTP client to HttpFS server (which doesn't involve Ratis).

@sadanand48
Copy link
Author

Got it. Thanks for explaining.

@szetszwo
Copy link
Contributor

szetszwo commented Aug 1, 2024

#1128 is merged. Closing this ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants