RATIS-2109. RaftLogBase#updateCommitIndex should return true only if …

…commitIndex is increased (#1109)
apache · Jun 12, 2024 · f3b9d12 · f3b9d12
1 parent f1725e2
commit f3b9d12
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/ratis-server/src/main/java/org/apache/ratis/server/raftlog/RaftLogBase.java b/ratis-server/src/main/java/org/apache/ratis/server/raftlog/RaftLogBase.java
@@ -124,15 +124,13 @@ public boolean updateCommitIndex(long majorityIndex, long currentTerm, boolean i
       final long newCommitIndex = Math.min(majorityIndex, getFlushIndex());
       if (oldCommittedIndex < newCommitIndex) {
         if (!isLeader) {
-          commitIndex.updateIncreasingly(newCommitIndex, traceIndexChange);
-          return true;
+          return commitIndex.updateIncreasingly(newCommitIndex, traceIndexChange);
         }
 
         // Only update last committed index for current term. See §5.4.2 in paper for details.
         final TermIndex entry = getTermIndex(newCommitIndex);
         if (entry != null && entry.getTerm() == currentTerm) {
-          commitIndex.updateIncreasingly(newCommitIndex, traceIndexChange);
-          return true;
+          return commitIndex.updateIncreasingly(newCommitIndex, traceIndexChange);
         }
       }
     }