RATIS-1071. NettyClientRpc supports sendRequestAsync. #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
reviewed
Jul 16, 2024
There was a problem hiding this comment.
Thanks @szetszwo for picking this up. I have a question related to one of the tests, other than that, it looks good.
| import org.junit.jupiter.api.Assertions; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| public class TestNettyClientRpcAsync extends BaseTest implements MiniRaftClusterWithNetty.FactoryGet { |
There was a problem hiding this comment.
Do we want to keep this test? According to #204 (comment) it can be removed, since we are also adding TestRaftAsyncWithNetty extends RaftAsyncTests.
There was a problem hiding this comment.
You are right. We don't need this test anymore.
SzyWilliam
approved these changes
Jul 16, 2024
|
Thanks @adoroszlai and @SzyWilliam for reviewing this! |
szetszwo
added a commit
that referenced
this pull request
Aug 22, 2024
…Rui Wang and Tsz-Wo Nicholas Sze. (#1122)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See RATIS-1071.
This is continuing the work in #204
When merging this pull request, please include "
Contributed by Rui Wang and Tsz-Wo Nicholas Sze".