Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RATIS-2150. No need for manual assembly:single execution when mvn deploy #1144

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

OneSizeFitsQuorum
Copy link
Contributor

see jira

Signed-off-by: OneSizeFitQuorum <[email protected]>
@OneSizeFitsQuorum
Copy link
Contributor Author

@szetszwo PTAL

Copy link
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good.

@adoroszlai adoroszlai changed the title RATIS-2150 No need for manual assembly:single execution when mvn depoly RATIS-2150. No need for manual assembly:single execution when mvn deploy Sep 7, 2024
Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @OneSizeFitsQuorum for the patch, LGTM.

(Please continue using your fork for pushing development branches, instead of apache/ratis.)

@OneSizeFitsQuorum
Copy link
Contributor Author

OneSizeFitsQuorum commented Sep 9, 2024

Thanks for reviewing! @szetszwo @adoroszlai

| Please continue using your fork for pushing development branches, instead of apache/ratis

got it!

@OneSizeFitsQuorum OneSizeFitsQuorum merged commit 37386c4 into master Sep 13, 2024
21 of 24 checks passed
@OneSizeFitsQuorum OneSizeFitsQuorum deleted the jira2150 branch September 13, 2024 02:16
OneSizeFitsQuorum added a commit that referenced this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants