Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RATIS-2164. LeakDetector has a race condition. #1163

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

RATIS-2164. LeakDetector has a race condition. #1163

wants to merge 1 commit into from

Conversation

szetszwo
Copy link
Contributor

@szetszwo szetszwo commented Oct 7, 2024

RATIS-2164

This is mainly fixing the first two problem mentioned in #1156

  1. LeakDetector: asserted allLeaks is non-empty but printed "allLeaks.size = 0"
    • Another bug: Trackers can be considered as a leak without calling retain(). Without calling retain() at all, it is not a leak.
  2. SimpleTracing and AdvancedTracing: the methods should be synchronized.
    • Minor presentation problem: AdvancedTracing should have a single track list instead of two lists: retainsTraces and releaseTraces.

@szetszwo
Copy link
Contributor Author

szetszwo commented Oct 7, 2024

@duongkame , @133tosakarin , @OneSizeFitsQuorum , @adoroszlai , please take a look.

@szetszwo
Copy link
Contributor Author

szetszwo commented Oct 7, 2024

The failures are expected since it needs the other fixes described in #1156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@133tosakarin 133tosakarin 133tosakarin approved these changes

@adoroszlai adoroszlai Awaiting requested review from adoroszlai

@OneSizeFitsQuorum OneSizeFitsQuorum Awaiting requested review from OneSizeFitsQuorum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szetszwo @133tosakarin