Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #1106] Send retry as a normal message when sendMessageBack fails #1107

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

redlsz
Copy link
Contributor

@redlsz redlsz commented Nov 13, 2023

What is the purpose of the change

fix #1106

Brief changelog

Send retry as a normal message when sendMessageBack fails. (Refer to Java SDK)

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@leizhiyuan
Copy link

@lizhanhui @francisoliverlee @lizhimins

Please review it when you have time. We have already conducted the test.

@lizhanhui lizhanhui merged commit 0e19ee6 into apache:master Apr 11, 2024
7 checks passed
@lizhanhui
Copy link

@leizhiyuan The behavior is aligning with Java counterparts, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Message may be lost when sendMessageBack fails
3 participants