Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix producer send msg timeout option does not take effect #1109

Merged
merged 3 commits into from
Nov 28, 2023
Merged

fix: fix producer send msg timeout option does not take effect #1109

merged 3 commits into from
Nov 28, 2023

Conversation

twz915
Copy link
Contributor

@twz915 twz915 commented Nov 27, 2023 •
edited
Loading

What is the purpose of the change

fix #1110 producer send msg timeout option does not take effect

rocketmq.NewProducer(
    producer.WithSendMsgTimeout(time.Second*3),
    producer.WithRetry(2),
)

In most cases, a fixed timeout of 3 seconds is written into the code, preventing the configuration from taking effect.

How to reproduce it?

add producer option producer.WithSendMsgTimeout(time.Microsecond*1) and send message, no err return. (io timeout expected)

@ShannonDing ShannonDing merged commit 7ae83c4 into apache:master Nov 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShannonDing ShannonDing ShannonDing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

producer send msg timeout option does not take effect
3 participants
@twz915 @ShannonDing @tuweizhong