[ISSUE #9080] Not hold final message store config in fetcher (#9086)

apache · Dec 30, 2024 · 7722ce7 · 7722ce7
1 parent 19393e0
commit 7722ce7
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/tieredstore/src/main/java/org/apache/rocketmq/tieredstore/core/MessageStoreFetcherImpl.java b/tieredstore/src/main/java/org/apache/rocketmq/tieredstore/core/MessageStoreFetcherImpl.java
@@ -56,7 +56,6 @@ public class MessageStoreFetcherImpl implements MessageStoreFetcher {
     private final String brokerName;
     private final MetadataStore metadataStore;
     private final MessageStoreConfig storeConfig;
-    private final org.apache.rocketmq.store.config.MessageStoreConfig messageStoreConfig;
     private final TieredMessageStore messageStore;
     private final IndexService indexService;
     private final FlatFileStore flatFileStore;
@@ -72,7 +71,6 @@ public MessageStoreFetcherImpl(TieredMessageStore messageStore, MessageStoreConf
         FlatFileStore flatFileStore, IndexService indexService) {
 
         this.storeConfig = storeConfig;
-        this.messageStoreConfig = messageStore.getMessageStoreConfig();
         this.brokerName = storeConfig.getBrokerName();
         this.flatFileStore = flatFileStore;
         this.messageStore = messageStore;
@@ -150,7 +148,8 @@ protected GetMessageResultExt getMessageFromCache(
             if (result.getMessageCount() == maxCount) {
                 break;
             }
-            if (result.getBufferTotalSize() >= messageStoreConfig.getMaxTransferBytesOnMessageInMemory()) {
+            long maxTransferBytes = messageStore.getMessageStoreConfig().getMaxTransferBytesOnMessageInMemory();
+            if (result.getBufferTotalSize() >= maxTransferBytes) {
                 break;
             }
         }