Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7231] Fix: proxy client language error #7200

Merged

Conversation

weihubeats
Copy link
Member

@weihubeats weihubeats commented Aug 17, 2023

#7231

The client actually uses go, and there is a bug in the language setting here.

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2023

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 42.95%. Comparing base (82b2f8e) to head (bcd07a4).
Report is 349 commits behind head on develop.

Files with missing lines Patch % Lines
...pache/rocketmq/remoting/protocol/LanguageCode.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7200      +/-   ##
=============================================
- Coverage      42.97%   42.95%   -0.03%     
+ Complexity      9670     9657      -13     
=============================================
  Files           1161     1161              
  Lines          83926    83929       +3     
  Branches       10898    10898              
=============================================
- Hits           36069    36049      -20     
- Misses         43380    43394      +14     
- Partials        4477     4486       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weihubeats
Copy link
Member Author

weihubeats commented Aug 18, 2023

@xdkxlk Can you help review this pr?

Copy link
Contributor

@joeCarf joeCarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are tests failures and plz give more information about this bug so I can help to review :)

@weihubeats
Copy link
Member Author

@joeCarf All ci checks have now been cleared.

@weihubeats weihubeats changed the title develop proxy language bugfix [ISSUE #7199] Fix: proxy client language error Aug 21, 2023
@weihubeats
Copy link
Member Author

done

Copy link
Contributor

@joeCarf joeCarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drpmma
Copy link
Contributor

drpmma commented Aug 22, 2023

The issue says that there is an NPE. But I don't see a relationship between the issue and this pr.

Could you please explain it?

java.lang.NullPointerException: null
at org.apache.rocketmq.proxy.grpc.v2.channel.GrpcClientChannel.processGetConsumerRunningInfo(GrpcClientChannel.java:213)
at org.apache.rocketmq.proxy.service.relay.ProxyChannel.writeAndFlush(ProxyChannel.java:97)
at org.apache.rocketmq.remoting.netty.NettyRemotingAbstract.invokeSyncImpl(NettyRemotingAbstract.java:476)
at org.apache.rocketmq.remoting.netty.NettyRemotingServer.invokeSync(NettyRemotingServer.java:438)
at org.apache.rocketmq.broker.client.net.Broker2Client.callClient(Broker2Client.java:80)
at org.apache.rocketmq.broker.processor.AdminBrokerProcessor.callConsumer(AdminBrokerProcessor.java:2347)
at org.apache.rocketmq.broker.processor.AdminBrokerProcessor.getConsumerRunningInfo(AdminBrokerProcessor.java:1979)
at org.apache.rocketmq.broker.processor.AdminBrokerProcessor.processRequest(AdminBrokerProcessor.java:278)
at org.apache.rocketmq.remoting.netty.NettyRemotingAbstract.lambda$buildProcessRequestHandler$1(NettyRemotingAbstract.java:312)
at org.apache.rocketmq.remoting.netty.RequestTask.run(RequestTask.java:80)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:750)

@weihubeats
Copy link
Member Author

There are two problems with this issues, one is null and the other is a language code problem that I can split into two issues

@weihubeats weihubeats changed the title [ISSUE #7199] Fix: proxy client language error [ISSUE #7231] Fix: proxy client language error Aug 22, 2023
@weihubeats
Copy link
Member Author

@drpmma I've changed issues, please help to relook at it

Copy link
Contributor

@drpmma drpmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weihubeats
Copy link
Member Author

@drpmma Can this pr be merged?

@weihubeats
Copy link
Member Author

Is this pr ready for merge, and are there any other issues that need to be dealt with?

@RongtongJin
Copy link
Contributor

@weihubeats How about merging lastest code to trigger CI again?

@weihubeats
Copy link
Member Author

@RongtongJin I merge the latest dev bis triggered ci, but a few cid still failed, I feel that this should not be the result of this modification, this test these failed use cases can be successful!

@RongtongJin
Copy link
Contributor

@RongtongJin I merge the latest dev bis triggered ci, but a few cid still failed, I feel that this should not be the result of this modification, this test these failed use cases can be successful!

I will rerun.

@weihubeats
Copy link
Member Author

Maybe this pr can be merged now. @RongtongJin

@RongtongJin RongtongJin merged commit 3968c18 into apache:develop Oct 20, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants