[ISSUE #7480] Fix the offset in the timerCheckPoint will not be corrected when the commitlog and consumeQueue are truncated #7488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…commitlog and consumeQueue are truncated
Codecov Report
@@ Coverage Diff @@
## develop #7488 +/- ##
=============================================
+ Coverage 42.93% 42.98% +0.04%
- Complexity 9660 9677 +17
=============================================
Files 1161 1161
Lines 83930 83959 +29
Branches 10898 10901 +3
=============================================
+ Hits 36038 36087 +49
+ Misses 43410 43399 -11
+ Partials 4482 4473 -9
... and 29 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lizhimins
reviewed
Oct 27, 2023
| ConsumeQueueInterface cq = this.messageStore.getConsumeQueue(TIMER_TOPIC, 0); | ||
|
|
||
| // Correction based consume queue | ||
| if (cq != null && currQueueOffset < cq.getMinOffsetInQueue()) { |
There was a problem hiding this comment.
currQueueOffset < cq.getMinOffsetInQueue() 这个情况什么时候出现，应该比较少吧
There was a problem hiding this comment.
主要是commitlog和cq数据被截断的时候，但timer这里是不会修正的
joeCarf
approved these changes
Nov 6, 2023
tsunghanjacktsai
approved these changes
Dec 4, 2024
ltamber
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #7480
Brief Description
Fix the offset in the timerCheckPoint will not be corrected when the commitlog and consumeQueue are truncated
How Did You Test This Change?