[ISSUE #7512] Simplify message sending at the basic layer and reduce redundant judgments #7513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # client/src/main/java/org/apache/rocketmq/client/impl/mqclient/MQClientAPIExt.java # proxy/src/main/java/org/apache/rocketmq/proxy/service/message/LocalMessageService.java
Codecov Report
@@ Coverage Diff @@
## develop #7513 +/- ##
=============================================
+ Coverage 42.98% 43.00% +0.01%
- Complexity 9674 9682 +8
=============================================
Files 1158 1158
Lines 83982 83963 -19
Branches 10916 10917 +1
=============================================
+ Hits 36102 36110 +8
+ Misses 43380 43359 -21
+ Partials 4500 4494 -6
... and 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
joeCarf
reviewed
Nov 14, 2023
| @@ -152,7 +150,9 @@ public CompletableFuture<SendResult> sendMessageAsync( | |||
| long timeoutMillis | |||
| ) { | |||
| SendMessageRequestHeaderV2 requestHeaderV2 = SendMessageRequestHeaderV2.createSendMessageRequestHeaderV2(requestHeader); | |||
| RemotingCommand request = RemotingCommand.createRequestCommand(RequestCode.SEND_MESSAGE_V2, requestHeaderV2); | |||
|
|
|||
| int code = requestHeader.isBatch() ? RequestCode.SEND_BATCH_MESSAGE : RequestCode.SEND_MESSAGE_V2; | |||
There was a problem hiding this comment.
code使用RequestCode类型，可读性会更好
| } | ||
| future = this.mqClientAPIFactory.getClient().sendMessageAsync( |
There was a problem hiding this comment.
这个部分的改动似乎没有必要，原有的写法我觉得没什么问题
| body = msgBatch.encode(); | ||
| msgBatch.setBody(body); | ||
| messageId = MessageClientIDSetter.getUniqID(msgBatch); | ||
| Message message; |
|
This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR. |
|
This PR was closed because it has been inactive for 3 days since being marked as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #issue_id
issue
Brief Description
How Did You Test This Change?