Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5923] Revert "Fix tiered store README.md error about Configuration (#7436)" #7557

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

lizhimins
Copy link
Member

@lizhimins lizhimins commented Nov 14, 2023

[ISSUE #5923] Revert "Fix tiered store README.md error about Configuration (#7436)"

This reverts commit 70dc93a.

Which Issue(s) This PR Fixes

for issue #5923

There is a widely use of filePath in the rocketmq project. The rename operation which not only brings compatibility issues but also conflicts with the naming style of the rocketmq project. It is recommended to revert this change.

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1be5ebc) 43.11% compared to head (0124da5) 43.17%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7557      +/-   ##
=============================================
+ Coverage      43.11%   43.17%   +0.05%     
- Complexity      9708     9719      +11     
=============================================
  Files           1159     1159              
  Lines          84035    84035              
  Branches       10922    10922              
=============================================
+ Hits           36234    36283      +49     
+ Misses         43294    43244      -50     
- Partials        4507     4508       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if we accept "filepath" as the default naming pattern, we should replace all the places in RocketMQ, not just tiered storage module.

@RongtongJin RongtongJin merged commit 4791d9a into apache:develop Nov 14, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants