Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7585] Support message filtering in rocketmq tiered storage #7594

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

lizhimins
Copy link
Member

Which Issue(s) This PR Fixes

Support #7585

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023

Codecov Report

Attention: 59 lines in your changes are missing coverage. Please review.

Comparison is base (a194e1e) 43.20% compared to head (956fdd8) 43.16%.
Report is 1 commits behind head on develop.

Files Patch % Lines
...che/rocketmq/tieredstore/TieredMessageFetcher.java 67.30% 26 Missing and 8 partials ⚠️
...e/rocketmq/tieredstore/util/MessageBufferUtil.java 72.72% 7 Missing and 2 partials ⚠️
...cketmq/tieredstore/common/GetMessageResultExt.java 69.23% 6 Missing and 2 partials ⚠️
...pache/rocketmq/tieredstore/TieredMessageStore.java 0.00% 2 Missing and 1 partial ⚠️
...q/tieredstore/common/TieredMessageStoreConfig.java 50.00% 2 Missing ⚠️
.../tieredstore/common/SelectBufferResultWrapper.java 88.88% 1 Missing ⚠️
...tieredstore/metrics/TieredStoreMetricsManager.java 0.00% 1 Missing ⚠️
...cketmq/tieredstore/provider/TieredFileSegment.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7594      +/-   ##
=============================================
- Coverage      43.20%   43.16%   -0.04%     
- Complexity      9785     9794       +9     
=============================================
  Files           1162     1164       +2     
  Lines          84376    84416      +40     
  Branches       10954    10960       +6     
=============================================
- Hits           36457    36441      -16     
- Misses         43394    43449      +55     
- Partials        4525     4526       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@joeCarf joeCarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, there are test failures~
image

@lizhimins
Copy link
Member Author

hi, there are test failures~ image

这个测试是 cq in rocksdb 的提交引入的

Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lollipopjin lollipopjin merged commit aec1055 into apache:develop Dec 4, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants