[ISSUE #7671] filter inner producer client when report to metrics #7673
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #7673 +/- ##
=============================================
- Coverage 43.17% 43.13% -0.05%
- Complexity 9797 9798 +1
=============================================
Files 1165 1165
Lines 84477 84486 +9
Branches 10966 10968 +2
=============================================
- Hits 36474 36441 -33
- Misses 43473 43516 +43
+ Partials 4530 4529 -1 ☔ View full report in Codecov by Sentry. |
| clone.forEach((group, map) -> { | ||
| if (MixAll.CLIENT_INNER_PRODUCER_GROUP.equals(group)) { | ||
| groupChannelTable.remove(group); | ||
| } |
There was a problem hiding this comment.
Maybe remove is unnecessary, we just need the filtered count.
There was a problem hiding this comment.
Thanks for your review, but I think remove in a clone map won't affect original map
|
@ShadowySpirits take a look at this pr |
| ConcurrentHashMap<String, ConcurrentHashMap<Channel, ClientChannelInfo>> clone = new ConcurrentHashMap<>(groupChannelTable); | ||
| clone.forEach((group, map) -> { | ||
| if (MixAll.CLIENT_INNER_PRODUCER_GROUP.equals(group)) { | ||
| groupChannelTable.remove(group); |
There was a problem hiding this comment.
looks that you removed the keys in groupChannelTable but used clone map at last
|
This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR. |
|
This PR was closed because it has been inactive for 3 days since being marked as stale. |
Which Issue(s) This PR Fixes
Fixes #7671
Brief Description
How Did You Test This Change?