Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #9042] Update createTimerMessageStore call with new parameter #9041

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

chi3316
Copy link
Contributor

@chi3316 chi3316 commented Dec 9, 2024

Which Issue(s) This PR Fixes

Fixes #9042

Brief Description

This PR resolves a compilation error caused by an outdated method parameter in TimerMessageStoreTest. The createTimerMessageStore method's parameters were updated previously, but a later PR did not rebase to the latest code, leading to mismatched method calls.

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.87%. Comparing base (6a94a02) to head (86fa02c).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9041      +/-   ##
=============================================
+ Coverage      47.83%   47.87%   +0.04%     
- Complexity     11836    11867      +31     
=============================================
  Files           1305     1312       +7     
  Lines          91344    91717     +373     
  Branches       11721    11749      +28     
=============================================
+ Hits           43690    43911     +221     
- Misses         42255    42384     +129     
- Partials        5399     5422      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chi3316 chi3316 changed the title Update createTimerMessageStore call with new parameter [ISSUE #9042]Update createTimerMessageStore call with new parameter Dec 9, 2024
@chi3316 chi3316 changed the title [ISSUE #9042]Update createTimerMessageStore call with new parameter [ISSUE #9042] Update createTimerMessageStore call with new parameter Dec 9, 2024
@RongtongJin RongtongJin merged commit 7da9ad4 into apache:develop Dec 10, 2024
11 checks passed
@chi3316 chi3316 deleted the hotfix-ci-error branch December 10, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Compilation error due to outdated method parameter in TimerMessageStoreTest
4 participants