Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #9025] [RIP-73] Pop Consumption Improvement Based on RocksDB #9048

Merged
merged 6 commits into from
Dec 20, 2024

Conversation

lizhimins
Copy link
Member

Which Issue(s) This PR Fixes

Fixes #9025

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 57.71429% with 444 lines in your changes missing coverage. Please review.

Project coverage is 47.97%. Comparing base (9aa081b) to head (8a16992).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
...apache/rocketmq/broker/pop/PopConsumerService.java 73.41% 40 Missing and 52 partials ⚠️
...rocketmq/broker/processor/PopMessageProcessor.java 19.64% 87 Missing and 3 partials ⚠️
...rocketmq/broker/processor/AckMessageProcessor.java 4.81% 77 Missing and 2 partials ⚠️
...q/tools/command/export/ExportPopRecordCommand.java 0.00% 47 Missing ⚠️
...broker/processor/ChangeInvisibleTimeProcessor.java 4.76% 39 Missing and 1 partial ⚠️
...g/apache/rocketmq/broker/pop/PopConsumerCache.java 85.27% 9 Missing and 10 partials ⚠️
.../java/org/apache/rocketmq/common/BrokerConfig.java 25.00% 18 Missing ⚠️
...ocketmq/broker/processor/AdminBrokerProcessor.java 0.00% 12 Missing and 1 partial ⚠️
...e/rocketmq/broker/pop/PopConsumerRocksdbStore.java 86.25% 7 Missing and 4 partials ⚠️
...a/org/apache/rocketmq/broker/BrokerController.java 33.33% 3 Missing and 5 partials ⚠️
... and 9 more
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9048      +/-   ##
=============================================
- Coverage      48.01%   47.97%   -0.04%     
- Complexity     11903    12032     +129     
=============================================
  Files           1312     1319       +7     
  Lines          91735    92743    +1008     
  Branches       11751    11895     +144     
=============================================
+ Hits           44042    44498     +456     
- Misses         42291    42736     +445     
- Partials        5402     5509     +107     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lizhimins lizhimins merged commit 35a6426 into apache:develop Dec 20, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] [RIP‐73] Pop Consumption Improvement Based on RocksDB
5 participants