Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #9115] Optimize the broker's reverse notification for consumerId change #9116

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

yx9o
Copy link
Contributor

@yx9o yx9o commented Jan 9, 2025

Fixes #9115 .

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 61.90476% with 8 lines in your changes missing coverage. Please review.

Project coverage is 47.94%. Comparing base (e0db654) to head (6a47b12).

Files with missing lines Patch % Lines
...roker/client/DefaultConsumerIdsChangeListener.java 61.90% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9116      +/-   ##
=============================================
- Coverage      48.05%   47.94%   -0.11%     
+ Complexity     12067    12041      -26     
=============================================
  Files           1320     1320              
  Lines          92840    92861      +21     
  Branches       11898    11900       +2     
=============================================
- Hits           44613    44523      -90     
- Misses         42726    42826     +100     
- Partials        5501     5512      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qianye1001
Copy link
Contributor

  1. task1 has already done notification
  2. task2 try interrupt task1 and update map
  3. task1 remove group in map

if so, task2 will never be interrupted, but it is better than now

@yx9o
Copy link
Contributor Author

yx9o commented Jan 13, 2025

  1. task1 has already done notification
  2. task2 try interrupt task1 and update map
  3. task1 remove group in map

if so, task2 will never be interrupted, but it is better than now

Hi, thank you for your review. I added the atomic check here. Please help review it again. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Optimize the broker's reverse notification for consumerId change
3 participants